Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove RKE and EKS NLB #335

Merged
merged 1 commit into from
Sep 9, 2024
Merged

remove RKE and EKS NLB #335

merged 1 commit into from
Sep 9, 2024

Conversation

DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented Sep 8, 2024

User description

  • don't need network load-balancer
  • using EKS instead of RKE

PR Type

enhancement, other


Description

  • Removed AWS Network Load Balancer configurations for both EKS Blue and Green environments, including target groups, listeners, and security group rules.
  • Deleted all AWS infrastructure configurations related to RKE, including EC2 instances, VPC, subnets, and security groups.
  • Removed Hetzner Cloud infrastructure configurations, including server instances and network settings.
  • Eliminated Rancher and K3s cluster configurations, including Helm releases, SSH resources, and local file outputs.
  • Deleted documentation files, including README and example Terraform variables.
  • Removed Makefile and .gitattributes, cleaning up project configuration files.

Changes walkthrough 📝

Relevant files
Enhancement
25 files
nlb.tf
Remove AWS Network Load Balancer configuration for EKS Blue

eks/eks-blue/nlb.tf

  • Removed the entire configuration for AWS Network Load Balancer (NLB).
  • Deleted target groups and listeners for TCP and UDP ports.
  • Removed security group rules related to the EKS cluster.
  • +0/-183 
    nlb.tf
    Remove AWS Network Load Balancer configuration for EKS Green

    eks/eks-green/nlb.tf

  • Removed the entire configuration for AWS Network Load Balancer (NLB).
  • Deleted target groups and listeners for TCP and UDP ports.
  • Removed security group rules related to the EKS cluster.
  • +0/-183 
    data.tf
    Remove AWS AMI data source configuration                                 

    rke/aws/data.tf

    • Removed data source configuration for AWS AMI.
    +0/-26   
    infra.tf
    Remove AWS EC2 and Rancher server configurations                 

    rke/aws/infra.tf

  • Removed AWS EC2 instance configurations for RKE cluster and Rancher
    server.
  • Deleted Rancher module and workload cluster configurations.
  • +0/-106 
    network.tf
    Remove AWS network infrastructure configurations                 

    rke/aws/network.tf

  • Removed AWS VPC, internet gateway, subnet, and route table
    configurations.
  • +0/-44   
    outputs.tf
    Remove AWS output configurations                                                 

    rke/aws/outputs.tf

  • Removed output configurations for Rancher server and workload node
    IPs.
  • +0/-11   
    provider.tf
    Remove AWS provider configuration                                               

    rke/aws/provider.tf

    • Removed AWS provider configuration and required providers block.
    +0/-26   
    security_group_elb.tf
    Remove security group configurations for ingress ELB         

    rke/aws/security_group_elb.tf

    • Removed security group configurations for ingress ELB.
    +0/-39   
    security_group_nodes.tf
    Remove security group configurations for RKE nodes             

    rke/aws/security_group_nodes.tf

    • Removed security group configurations for RKE nodes.
    +0/-69   
    ssh.tf
    Remove SSH key pair and local file configurations               

    rke/aws/ssh.tf

    • Removed SSH key pair and local file configurations.
    +0/-21   
    variables.tf
    Remove AWS infrastructure module variables                             

    rke/aws/variables.tf

    • Removed variable definitions for AWS infrastructure module.
    +0/-78   
    infra.tf
    Remove Hetzner Cloud infrastructure configurations             

    rke/hetzner/infra.tf

    • Removed Hetzner Cloud infrastructure configurations.
    +0/-128 
    output.tf
    Remove Hetzner Cloud output configurations                             

    rke/hetzner/output.tf

    • Removed output configurations for Hetzner Cloud.
    +0/-12   
    provider.tf
    Remove Hetzner Cloud provider configuration                           

    rke/hetzner/provider.tf

    • Removed Hetzner Cloud provider configuration.
    +0/-21   
    variables.tf
    Remove Hetzner Cloud infrastructure module variables         

    rke/hetzner/variables.tf

  • Removed variable definitions for Hetzner Cloud infrastructure module.
  • +0/-82   
    data.tf
    Remove Rancher certificates data source configuration       

    rke/rancher-common/data.tf

    • Removed data source configuration for Rancher certificates.
    +0/-11   
    helm.tf
    Remove Helm release configurations for cert-manager and Rancher

    rke/rancher-common/helm.tf

    • Removed Helm release configurations for cert-manager and Rancher.
    +0/-43   
    k3s.tf
    Remove K3s cluster installation and configuration               

    rke/rancher-common/k3s.tf

    • Removed K3s cluster installation and configuration.
    +0/-22   
    local.tf
    Remove local file configurations for kubeconfig files       

    rke/rancher-common/local.tf

    • Removed local file configurations for kubeconfig files.
    +0/-12   
    output.tf
    Remove Rancher URL and admin credentials outputs                 

    rke/rancher-common/output.tf

  • Removed output configurations for Rancher URL and admin credentials.
  • +0/-21   
    provider.tf
    Remove provider configurations for Helm, Rancher2, and SSH

    rke/rancher-common/provider.tf

    • Removed provider configurations for Helm, Rancher2, and SSH.
    +0/-48   
    rancher.tf
    Remove Rancher server initialization and cluster creation resources

    rke/rancher-common/rancher.tf

  • Removed Rancher server initialization and cluster creation resources.
  • +0/-34   
    variables.tf
    Remove Rancher common module variables                                     

    rke/rancher-common/variables.tf

    • Removed variable definitions for Rancher common module.
    +0/-61   
    userdata_node.template
    Remove userdata script for AWS EC2 instance configuration

    rke/aws/files/userdata_node.template

    • Removed userdata script for AWS EC2 instance configuration.
    +0/-8     
    userdata_node.template
    Remove userdata script for Hetzner Cloud instance configuration

    rke/hetzner/files/userdata_node.template

    • Removed userdata script for Hetzner Cloud instance configuration.
    +0/-3     
    Miscellaneous
    2 files
    .gitattributes
    Remove line ending configuration                                                 

    rke/.gitattributes

    • Removed line ending configuration.
    +0/-1     
    Makefile
    Remove Makefile with Terraform operation targets                 

    rke/Makefile

    • Removed Makefile with targets for Terraform operations.
    +0/-27   
    Documentation
    2 files
    README.md
    Remove README documentation for Rancher Management Server

    rke/README.md

    • Removed README documentation for Rancher Management Server.
    +0/-35   
    terraform.tfvars.example
    Remove example Terraform variables file for Rancher common module

    rke/rancher-common/terraform.tfvars.example

    • Removed example Terraform variables file for Rancher common module.
    +0/-36   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    - don't need network load-balancer
    - using EKS instead of RKE
    @github-actions github-actions bot added enhancement New feature or request other labels Sep 8, 2024
    Copy link

    github-actions bot commented Sep 8, 2024

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link

    github-actions bot commented Sep 8, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @DaMandal0rian DaMandal0rian merged commit f7d3325 into main Sep 9, 2024
    2 checks passed
    @DaMandal0rian DaMandal0rian deleted the remove-unused-infra branch September 9, 2024 11:55
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants