-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credit management (backend) #58
Conversation
✅ Deploy Preview for auto-drive-demo canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems very cater to individual use and not organization use at all.
Even if it's maybe out of spec, I feel we should at least design the db and structure to support both.
I'll suggest (if out of spec) also creating a org table, and automatically creating a org for each users and tied the api to the org+user, this way we will be able to extend functionality more easily in the future
The credit management is true that is too coupled to the individual. For solving this we could have a The link between an organization and its members I think is straightforward to implement from this point so there's no need to implement yet:
I don't see desirable to merge |
Btw, I misunderstood sth in the issue #8 the limits are intended to be monthly limit instead of a fixed limit, I have to update that aswell. The prev comment still applies |
Updates: As we discussed internally, a single-member organization is created when a user "onboards" (signs up). Each organization has a subscription that has passed from having a counter of For accounting the uploads and downloads there is the table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implemented backend changes described in #8:
Admin users management:
"role"
tousers
tableCredit management:
user
table:download_credits
andupload_credits
for limit user's activity.AdminRole
could increment upload and download credits.Api Keys: