You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complexity and Size The file is extremely large (3281 lines), which could make maintenance and understanding difficult. Consider splitting into smaller, more manageable components.
Code Duplication There is a pattern of repeated code for creating and fetching data models (e.g., createOperatorTotalRewardsCollected and getOrCreateOperatorTotalRewardsCollected). Consider refactoring to reduce duplication, possibly by using higher-order functions or generics.
Correct the type of _in to match expected integer inputs
The _in field in Int_Array_Comparison_Exp should be an array of integers instead of an array of arrays of integers to match the expected input type for integer comparisons.
Why: This suggestion corrects a potential bug by ensuring the type matches the expected input, which is critical for the correct functioning of integer comparisons.
10
Best practice
Improve type safety by specifying more precise types
Consider using a more specific type than any for the input and output fields in the numeric and timestamptz types to improve type safety and clarity in your TypeScript code.
Why: This suggestion improves type safety and clarity, which is crucial in TypeScript for catching errors early and improving code maintainability. The proposed types are more specific and appropriate for the fields in question.
9
Use boolean type for _is_null to reflect its logical usage
For the _is_null field in the Boolean_Comparison_Exp and Int_Array_Comparison_Exp, consider using a type that explicitly represents a boolean (true or false) instead of InputMaybe<Scalars['Boolean']['input']>, as _is_null logically represents a boolean state.
Why: Using a boolean type for _is_null is more logical and improves code readability and correctness. This change aligns the type with its intended use, reducing potential confusion.
8
Robustness
Add error handling to Apollo client queries to enhance robustness
Consider adding error handling for the Apollo client query within the LeaderboardList component. This will improve the robustness of the component by handling potential errors that might occur during data fetching.
Why: Adding error handling is crucial for robustness and user experience, as it ensures that potential errors during data fetching are properly managed and communicated.
9
Enhancement
Add error handling for schema generation to improve robustness
Consider adding error handling or a fallback mechanism for the schema generation in the configuration. This can help ensure that the application behaves predictably in case the defaultIndexer.squids.leaderboard schema is not available or fails to load.
Why: Adding error handling and a fallback mechanism for the schema generation improves the robustness and predictability of the application, especially if the schema fails to load.
8
Add missing fields to Bundle_Author_Order_By for consistency
Ensure that the Bundle_Author_Order_By type includes ordering options for all fields in the Bundle_Author type to maintain consistency and full functionality in ordering queries.
export type Bundle_Author_Order_By = {
account?: InputMaybe<Account_Order_By>;
account_id?: InputMaybe<Order_By>;
bundle?: InputMaybe<Bundle_Order_By>;
bundle_id?: InputMaybe<Order_By>;
id?: InputMaybe<Order_By>;
operator?: InputMaybe<Operator_Order_By>;
operator_id?: InputMaybe<Order_By>;
+ // Add any missing fields here
};
Suggestion importance[1-10]: 7
Why: While the suggestion is valid for maintaining consistency, it lacks specific details on which fields are missing. It is a good enhancement but not critical without knowing the exact missing fields.
7
Maintainability
Reduce code duplication by using a map function for tabs
Refactor the repeated use of Tab and LeaderboardList components in the Leaderboard component to use a map function over an array of tab configurations. This will reduce code duplication and improve maintainability.
Why: Refactoring to use a map function reduces code duplication and improves maintainability, making the codebase easier to manage and extend in the future.
8
Refactor scalar type definitions using a generic utility type
Refactor the scalar type definitions to use a generic utility type for better maintainability and to avoid redundancy. This approach can help in managing changes to the scalar types more efficiently.
Why: Refactoring the scalar type definitions to use a generic utility type enhances maintainability and reduces redundancy, making future changes easier to manage.
7
Improve the structure of the return statement for future extensibility
Replace the direct return of the component with a more structured return statement that includes a React fragment. This will make it easier to add additional components or logic in the future without restructuring the return statement.
Why: The suggestion improves maintainability by making it easier to add additional components or logic in the future. However, it is not crucial and brings only a small improvement.
5
Performance
Use memoization for the isDesktop variable to improve performance
It's recommended to use memoization for the isDesktop variable to avoid unnecessary re-renders when the component state or props do not change. This can enhance performance, especially in components that rely heavily on responsive design features.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
enhancement
User description
Add leaderboard-squid and leaderboard v2
Screenshots
PR Type
enhancement, tests
Description
leaderboard-squid.ExplorerQueryStateinterface and removed unused imports.AccountLeaderboardcomponent.Changes walkthrough 📝
5 files
v0.ts
Add comprehensive type definitions for leaderboard-squidindexers/leaderboard-squid/src/types/v0.ts
sts.Typestructures.leaderboard.query.ts
Add GraphQL queries for leaderboard metricsexplorer/src/components/Leaderboard/leaderboard.query.ts
extrinsic counts.
cache.ts
Implement caching mechanism for leaderboard dataindexers/leaderboard-squid/src/utils/cache.ts
query.ts
Update ExplorerQueryState interfaceexplorer/src/states/query.ts
ExplorerQueryStateinterface.page.tsx
Update leaderboard page to use AccountLeaderboard componentexplorer/src/app/[chain]/leaderboard/page.tsx
AccountLeaderboardcomponent.87 files
leaderboard.ts
...explorer/gql/types/leaderboard.ts
...
staking.ts
...explorer/gql/types/staking.ts
...
storage.ts
...indexers/leaderboard-squid/src/types/domains/storage.ts
...
v5.ts
...indexers/leaderboard-squid/src/types/v5.ts
...
v1.ts
...indexers/leaderboard-squid/src/types/v1.ts
...
storage.ts
...indexers/leaderboard-squid/src/types/system/storage.ts
...
storage.ts
...indexers/leaderboard-squid/src/types/subspace/storage.ts
...
storage.ts
...indexers/leaderboard-squid/src/types/balances/storage.ts
...
index.tsx
...explorer/src/components/Leaderboard/index.tsx
...
sort.ts
...indexers/leaderboard-squid/src/utils/sort.ts
...
account.ts
...indexers/leaderboard-squid/src/storage/account.ts
...
LeaderboardList.tsx
...explorer/src/components/Leaderboard/LeaderboardList.tsx
...
events.ts
...indexers/leaderboard-squid/src/types/balances/events.ts
...
calls.ts
...indexers/leaderboard-squid/src/types/domains/calls.ts
...
staking.ts
...indexers/leaderboard-squid/src/events/staking.ts
...
events.ts
...indexers/leaderboard-squid/src/types/domains/events.ts
...
operator.ts
...indexers/leaderboard-squid/src/storage/operator.ts
...
farmer.ts
...indexers/leaderboard-squid/src/storage/farmer.ts
...
v3.ts
...indexers/leaderboard-squid/src/types/v3.ts
...
constants.ts
...indexers/leaderboard-squid/src/types/domains/constants.ts
...
farmer.ts
...indexers/leaderboard-squid/src/events/farmer.ts
...
constants.ts
...indexers/leaderboard-squid/src/types/subspace/constants.ts
...
support.ts
...indexers/leaderboard-squid/src/types/support.ts
...
storage.ts
...indexers/leaderboard-squid/src/types/transaction-fees/storage.ts
...
calls.ts
...indexers/leaderboard-squid/src/types/system/calls.ts
...
nominator.ts
...indexers/leaderboard-squid/src/storage/nominator.ts
...
account.ts
...indexers/leaderboard-squid/src/events/account.ts
...
calls.ts
...indexers/leaderboard-squid/src/types/balances/calls.ts
...
extrinsic.ts
...indexers/leaderboard-squid/src/events/extrinsic.ts
...
storage.ts
...indexers/leaderboard-squid/src/types/rewards/storage.ts
...
processor.ts
...indexers/leaderboard-squid/src/processor.ts
...
index.ts
...indexers/leaderboard-squid/src/events/index.ts
...
calls.ts
...indexers/leaderboard-squid/src/types/subspace/calls.ts
...
events.ts
...indexers/leaderboard-squid/src/types/system/events.ts
...
index.ts
...indexers/leaderboard-squid/src/utils/index.ts
...
constants.ts
...indexers/leaderboard-squid/src/types/balances/constants.ts
...
constants.ts
...indexers/leaderboard-squid/src/types/system/constants.ts
...
constants.ts
...indexers/leaderboard-squid/src/types/rewards/constants.ts
...
constants.ts
...indexers/leaderboard-squid/src/types/transaction-payment/constants.ts
...
events.ts
...indexers/leaderboard-squid/src/types/transaction-fees/events.ts
...
constants.ts
...indexers/leaderboard-squid/src/types/transaction-fees/constants.ts
...
indexers.ts
...explorer/src/constants/indexers.ts
...
OperatorsList.tsx
...explorer/src/components/Staking/OperatorsList.tsx
...
fee.ts
...indexers/leaderboard-squid/src/events/fee.ts
...
storage.ts
...indexers/leaderboard-squid/src/types/transaction-payment/storage.ts
...
events.ts
...indexers/leaderboard-squid/src/types/subspace/events.ts
...
index.ts
...indexers/leaderboard-squid/src/blocks/index.ts
...
events.ts
...indexers/leaderboard-squid/src/types/rewards/events.ts
...
page.tsx
...explorer/src/app/[chain]/leaderboard/accounts/page.tsx
...
ChainProvider.tsx
...explorer/src/providers/ChainProvider.tsx
...
MyPositionSwitch.tsx
...explorer/src/components/common/MyPositionSwitch.tsx
...
LeaderboardHeader.tsx
...explorer/src/components/layout/LeaderboardHeader.tsx
...
staking.query.ts
...explorer/src/components/Staking/staking.query.ts
...
OperatorNominatorTable.tsx
...explorer/src/components/Staking/OperatorNominatorTable.tsx
...
calls.ts
...indexers/leaderboard-squid/src/types/rewards/calls.ts
...
events.ts
...indexers/leaderboard-squid/src/types/transaction-payment/events.ts
...
number.ts
...explorer/src/utils/number.ts
...
page.tsx
...explorer/src/app/[chain]/leaderboard/nominators/page.tsx
...
page.tsx
...explorer/src/app/[chain]/leaderboard/operators/page.tsx
...
main.ts
...indexers/leaderboard-squid/src/main.ts
...
page.tsx
...explorer/src/app/[chain]/leaderboard/farmers/page.tsx
...
codegen.ts
...explorer/codegen.ts
...
index.ts
...indexers/leaderboard-squid/src/types/index.ts
...
constants.ts
...indexers/leaderboard-squid/src/types/constants.ts
...
events.ts
...indexers/leaderboard-squid/src/types/events.ts
...
storage.ts
...indexers/leaderboard-squid/src/types/storage.ts
...
routes.ts
...explorer/src/constants/routes.ts
...
calls.ts
...indexers/leaderboard-squid/src/types/calls.ts
...
index.ts
...indexers/leaderboard-squid/src/model/index.ts
...
1723206699043-Data.js
...indexers/leaderboard-squid/db/migrations/1723206699043-Data.js
...
docker-run.sh
...indexers/leaderboard-squid/scripts/docker-run.sh
...
gemini3h.jsonl
...indexers/leaderboard-squid/gemini3h.jsonl
...
package-lock.json
...indexers/leaderboard-squid/package-lock.json
...
README.md
...indexers/leaderboard-squid/README.md
...
schema.graphql
...indexers/leaderboard-squid/schema.graphql
...
commands.json
...indexers/leaderboard-squid/commands.json
...
package.json
...indexers/leaderboard-squid/package.json
...
typegen.json
...indexers/leaderboard-squid/typegen.json
...
LICENSE
...indexers/leaderboard-squid/LICENSE
...
squid.yaml
...indexers/leaderboard-squid/squid.yaml
...
tsconfig.json
...indexers/leaderboard-squid/tsconfig.json
...
.env
...indexers/leaderboard-squid/.env
...
docker-compose.yml
...indexers/leaderboard-squid/docker-compose.yml
...
astral.code-workspace
....vscode/astral.code-workspace
...
.squidignore
...indexers/leaderboard-squid/.squidignore
...
.dockerignore
...indexers/leaderboard-squid/.dockerignore
...
.npmrc
...indexers/leaderboard-squid/.npmrc
...