New commands for CLI: sample-config, report-config, init, results ; Refactoring CLI #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
danrgll
commented
Sep 17, 2024
•
danrgll
commented
- neps sample-config --"worker_id" --number-of-configs <"int">
- neps init --database; creates a neps state from e.g. run_config.yaml
- neps report-config <"trial-id"> <"reported-as"> --loss --cost --duration --time-end --tb --err --learning-curve --"worker-id"
- improve code maintenance
- neps results --dump-all-configs <"format"> --dump-incumbents <"format">
danrgll
changed the title
danrgll
changed the title
danrgll
changed the title
eddiebergman
requested changes
Sep 19, 2024
danrgll
changed the title
danrgll
changed the title
eddiebergman
requested changes
Oct 2, 2024
neps/utils/cli.py
Outdated
Comment on lines
80
to
113
| root_dir = Path(args.root_directory) | ||
| if validate_directory(root_dir): | ||
| return root_dir | ||
| else: | ||
| return None | ||
|
|
||
| # Configuration file handling | ||
| config_path = Path("run_config.yaml") | ||
| if config_path.exists(): | ||
| with config_path.open("r") as file: | ||
| config = yaml.safe_load(file) | ||
| try: | ||
| with config_path.open("r") as file: | ||
| config = yaml.safe_load(file) | ||
| except yaml.YAMLError as e: | ||
| print(f"Error parsing '{config_path}': {e}") | ||
| return None | ||
|
|
||
| root_directory = config.get(ROOT_DIRECTORY) | ||
| if root_directory: | ||
| root_directory_path = Path(root_directory) | ||
| if not root_directory_path.exists() or not root_directory_path.is_dir(): | ||
| print( | ||
| f"Error: The directory {root_directory_path} does not exist or is " | ||
| f"not a " | ||
| f"directory." | ||
| ) | ||
| if validate_directory(root_directory_path): | ||
| return root_directory_path | ||
| else: | ||
| return None | ||
| return root_directory_path | ||
| else: | ||
| raise ValueError( | ||
| "The config.yaml file exists but does not contain 'root_directory'." | ||
| print( | ||
| "Error: The 'run_config.yaml' file exists but does not contain the 'root_directory' key." | ||
| ) | ||
| return None | ||
| else: | ||
| raise ValueError( | ||
| "Either the root_directory must be provided as an argument or config.yaml " | ||
| "must exist with a 'root_directory' key." | ||
| print( | ||
| "Error: 'root_directory' must be provided as a command-line argument " | ||
| "or defined in 'run_config.yaml'." | ||
| ) | ||
| return None |
There was a problem hiding this comment.
One thing that might make this a bit more informative is to call config_path = Path("run_config.yaml").resolve() and to use this path in the errors printed. Gives a bit more information on the complete path that is being looked for.
Comment on lines
+633
to
+634
| trials = neps_state.get_all_trials() | ||
| sorted_trials = sorted(trials.values(), key=lambda x: int(x.id)) |
There was a problem hiding this comment.
This actually silently fails as a config id for multifidelity is actually something like 9_1, which int("9_1") gets convereted to 91.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.