Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Address the Issue#148 and clean _search() function #165

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

[refactor] Address the Issue#148 and clean _search() function #165

wants to merge 10 commits into from

Commits on Apr 12, 2021

  1. [refactor] Separate processing inside BaseTask._search() function 

    Since the readability of the function was quite bad,
I separated the processing.
I mostly copied and pasted the original processing and
checked if we can run some examples.
    @nabenabe0928
    nabenabe0928 committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    7186348 View commit details
    Browse the repository at this point in the history

  2. [refactor] Add _search_settings to make _search() function shorter

    @nabenabe0928
    nabenabe0928 committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ff1d7d3 View commit details
    Browse the repository at this point in the history

  3. [fix] Resolve all the mypy issues

    @nabenabe0928
    nabenabe0928 committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ec1a508 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. [fix] Fix a condition

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    eceae70 View commit details
    Browse the repository at this point in the history

  2. [merge] Merge the latest update in refactor_developtment

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    9481437 View commit details
    Browse the repository at this point in the history

  3. [fix] Fix mypy issues

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    b7726a8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'refactor_development' into refactor_basetask

    @nabenabe0928
    nabenabe0928 authored Apr 14, 2021
    Configuration menu
    Copy the full SHA
    6bc1302 View commit details
    Browse the repository at this point in the history

  5. [merge] Complete merge with refactor_development

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    60b71e0 View commit details
    Browse the repository at this point in the history

  6. [fix] Fix a flake8 issue

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    432cd07 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. [fix] Fix a bug from the rebase in test_api

    @nabenabe0928
    nabenabe0928 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    91d56da View commit details
    Browse the repository at this point in the history