Remove stale TODOs #1764
Merged
Remove stale TODOs #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/datastore
ecordell
reviewed
Feb 23, 2024
pkg/datastore/test/tuples.go
Outdated
| @@ -384,8 +384,8 @@ func DeleteRelationshipsTest(t *testing.T, tester DatastoreTester) { | |||
|
|
|||
| tRequire := testfixtures.TupleChecker{Require: require, DS: ds} | |||
|
|
|||
| // TODO temporarily store tuples in multiple calls to ReadWriteTransaction since no Datastore | |||
| // handles correctly duplicate tuples | |||
| // NOTE: we tuples in multiple calls to ReadWriteTransaction because it is not allowed to change | |||
There was a problem hiding this comment.
Ah, yes... I meant "I tuples". Good catch
(On a serious note: Fixed)
josephschorr
force-pushed
the
remove-stale-todos
branch
from
64ae169
to
a75660d
Compare
vroldanbet
previously approved these changes
Feb 26, 2024
github-actions
bot
added
the
area/tooling
Most of the removed TODOs are changes that we won't end up making. In the case of the MySQL datastore, the Postgres datastore implementation from which it was copied has diverged significantly, so there isn't really a reason to try to refactor into a combined datastore anymore (since the PG one uses PG-specific code)
josephschorr
force-pushed
the
remove-stale-todos
branch
from
aa1a2c4
to
6390b78
Compare
github-actions
bot
removed
the
area/tooling
vroldanbet
approved these changes
Feb 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the removed TODOs are changes that we won't end up making. In the case of the MySQL datastore, the Postgres datastore implementation from which it was copied has diverged significantly, so there isn't really a reason to try to refactor into a combined datastore anymore (since the PG one uses PG-specific code)