Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: htmlify, update links #1745

Merged
merged 3 commits into from
Feb 20, 2024
Merged

README: htmlify, update links #1745

merged 3 commits into from
Feb 20, 2024

Conversation

jzelinskie
Copy link
Member

@jzelinskie jzelinskie commented Feb 17, 2024 •
edited
Loading

  • reworked heading for README including light/dark logos, tagline, new badges
  • replaced features with why section focusing on value rather than functionality
  • swapped youtube videos to the language primer

@jzelinskie jzelinskie marked this pull request as ready for review February 17, 2024 23:42
@jzelinskie jzelinskie requested a review from a team as a code owner February 17, 2024 23:42
@github-actions github-actions bot added the area/docs Affects docs or metadata (e.g. README) label Feb 17, 2024
@jzelinskie jzelinskie force-pushed the html-readme branch 3 times, most recently from acb1128 to 1619873 Compare February 18, 2024 04:07
@github-actions github-actions bot added the area/CLI Affects the command line label Feb 18, 2024
samkim
samkim reviewed Feb 18, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
samkim
samkim reviewed Feb 18, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@samkim
Copy link
Member

samkim commented Feb 18, 2024

Left a few suggestions. Really like the update!

@jzelinskie
Copy link
Member Author

ptal @josephschorr @samkim

josephschorr
josephschorr approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie jzelinskie merged commit 380da03 into authzed:main Feb 20, 2024
15 checks passed
@jzelinskie jzelinskie deleted the html-readme branch February 20, 2024 22:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samkim samkim samkim left review comments

@josephschorr josephschorr josephschorr approved these changes

Assignees
No one assigned
Labels
area/CLI Affects the command line area/docs Affects docs or metadata (e.g. README)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzelinskie @samkim @josephschorr