Merge pull request #1769 from josephschorr/fix-retry-test-flake

Fix flake on transaction retry test by specifying a longer timeout
authzed · Feb 28, 2024 · 66a871c · 66a871c
2 parents 5a32447 + 0379e0f
commit 66a871c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/datastore/test/transactions.go b/pkg/datastore/test/transactions.go
@@ -36,7 +36,7 @@ func RetryTest(t *testing.T, tester DatastoreTester) {
 
 			ds := rawDS.(TestableDatastore)
 
-			ctx, cancel := context.WithTimeout(context.Background(), 500*time.Millisecond)
+			ctx, cancel := context.WithTimeout(context.Background(), 1500*time.Millisecond)
 			defer cancel()
 
 			var attempts int
@@ -48,7 +48,10 @@ func RetryTest(t *testing.T, tester DatastoreTester) {
 				}
 				return errors.New("not retryable")
 			}, tc.txOptions...)
+
+			require.GreaterOrEqual(attempts, 1)
 			require.Error(err)
+
 			retries := attempts - 1
 			tc.countAssertion(t, retries)
 		})