Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter name change for Organizations for Client Credentials #1052

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Nov 7, 2024

Changes

parameter name change in model GetOrganizationClientGrants200ResponseOneOf

the parameter was specified 'grants' in the api docs when it should actually be 'client-grants', this patch fixes the discrepancy

References

Please include relevant links supporting this change such as a:

GET /api/v2/organizations/{id}/client-grants

{
  "client_grants": [......],
  "start": 0,
  "limit": 50,
  "total": 1
}

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
➜ npm run test                                                         
Test Suites: 42 passed, 42 total
Tests:       1346 passed, 1346 total
Snapshots:   0 total
Time:        7.72 s, estimated 8 s

Checklist

…OneOf, the parameter was specified 'grants' in the api docs when it should actually be 'client-grants', this patch fixes the discrepancy
@tusharpandey13 tusharpandey13 requested a review from a team as a code owner November 7, 2024 11:11
@tusharpandey13 tusharpandey13 changed the title parameter name change in model GetOrganizationClientGrants200ResponseOneOf, the parameter was specified 'grants' in the api docs when it should actually be 'client-grants', this patch fixes the discrepancy parameter name change for Organizations for Client Credentials Nov 7, 2024
@tusharpandey13 tusharpandey13 enabled auto-merge (squash) November 7, 2024 11:13
@tusharpandey13 tusharpandey13 merged commit d704707 into master Nov 7, 2024
4 checks passed
@tusharpandey13 tusharpandey13 deleted the org-cc/patch1 branch November 7, 2024 11:20
kushalshit27 added a commit that referenced this pull request Nov 7, 2024
@@ -6533,7 +6533,7 @@ export interface GetOrganizationClientGrants200ResponseOneOf {
total: number;
/**
*/
grants: Array<GetOrganizationClientGrants200ResponseOneOfInner>;
'client-grants': Array<GetOrganizationClientGrants200ResponseOneOfInner>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's client_grants

@tusharpandey13 tusharpandey13 mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants