Fix branding template body path parsing issue

[kushalshit27]

🔧 Changes

📚 References

• Issue The branding location changes is a breaking change #941

🔬 Testing

Testing has been done considering different path for POSIX and Windows.
For tenant.yaml:
POSIX path on yaml:

    - template: universal_login
      body: ./branding_templates/universal_login.html

Windows path on yaml:

    - template: universal_login
      body: .\branding_templates\universal_login.html

Same test has been done for json(directory) export/import.

📝 Checklist

• All new/changed/fixed functionality is covered by tests (or N/A)
• I have added documentation for all new/changed functionality (or N/A)

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.32%. Comparing base (4b062cf) to head (1a66515).

Files	Patch %	Lines
src/utils.ts	80.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #943      +/-   ##
==========================================
- Coverage   84.33%   84.32%   -0.01%     
==========================================
  Files         116      116              
  Lines        3791     3802      +11     
  Branches      743      745       +2     
==========================================
+ Hits         3197     3206       +9     
- Misses        328      329       +1     
- Partials      266      267       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vasantteja]

Quick question, our pipeline is failing with this error
2024-08-14T15:13:07.881Z - error: Problem running command import 2024-08-14T15:13:07.881Z - error: Problem deploying branding, Error: Unable to load file /universal_login.html due to Error: ENOENT: no such file or directory, access '/branding_templates/universal_login.html
Does this pr solve this issue.

[kushalshit27]

Hi, @vasantteja
This should solve the error:

I have tested for tenant.yaml:
POSIX path on yaml:

    - template: universal_login
      body: ./branding_templates/universal_login.html

Windows path on yaml:

    - template: universal_login
      body: .\branding_templates\universal_login.html

Same test has been done for json(directory) export/import.

[vasantteja]

Hi, @vasantteja This should solve the error:

I have tested for tenant.yaml: POSIX path on yaml:

    - template: universal_login
      body: ./branding_templates/universal_login.html

Windows path on yaml:

    - template: universal_login
      body: .\branding_templates\universal_login.html

Same test has been done for json(directory) export/import.

Thanks for the update. Appreciate the help.

[vasantteja]

Hi @kushalshit27,

I noticed that another PR related to this issue was merged in version 7.24.1. I used it to run our pipeline, but it failed with the same error mentioned above. I assume our issue will not be resolved until this PR is merged. Do you have any idea when this PR will be merged?

[kushalshit27]

@vasantteja planning to release today!