Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue 875 #876

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Bugfix/issue 875 #876

merged 3 commits into from
Dec 22, 2023

Conversation

BavoLuysterborg
Copy link
Contributor

@BavoLuysterborg BavoLuysterborg commented Dec 18, 2023

🔧 Changes

📚 References

🔬 Testing

  • Covered by unit test
  • Manual testing:
  1. Import log stream of the format
logStreams:
  - name: Azure Event Grid
    filters:
      - type: category
        name: auth.token_exchange.fail
      - ...
    sink:
      azureSubscriptionId: <subscription id>
      azureRegion: <region>
      azureResourceGroup: <resource group>
      azurePartnerTopic: <partner topic name>
    status: active
    type: eventgrid
  1. Create operation should succeed

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@BavoLuysterborg BavoLuysterborg requested a review from a team as a code owner December 18, 2023 11:36
@willvedd
Copy link
Contributor

Thanks for opening this PR. This is exactly what should be done here. I'll be able to take a closer look today but hopefully can merge soon.

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to regenerate HTTP recordings but otherwise everything looks good. Thank you!

@willvedd
Copy link
Contributor

I can confirm that the E2E are running and passing locally so going to merge.

@willvedd willvedd merged commit 69b8cef into auth0:master Dec 22, 2023
6 of 7 checks passed
kushalshit27 pushed a commit that referenced this pull request Sep 26, 2024
* Strip sink.azurePartnerTopic in Log Stream create operations (#875)

* Add unit test to validate fix for #875

* Regenerating recordings

---------

Co-authored-by: Will Vedder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure EventGrid Log Stream creation fails
2 participants