Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling keyword preservation for wider array of resources #864

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Nov 18, 2023

🔧 Changes

As noted by #845 , the guardian set of resources are not having their correlating keywords preserved.

The issue here is that these resources leverage the name property as the primary identifier. However, the existing logic for keyword preservation does not allow for this identifier to be used; this is a bug. The solution, courtesy of @brendenpalmer is to support all identifiers but only use the ones that correlate to an existing field.

This change enables keyword preservation for a wider array of resources that were previously in a broken state.

📚 References

🔬 Testing

Added a couple new unit test cases to the main keyword preservation test. These demonstrate that the guardianFactorProviders and pages resources are working as expected.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner November 18, 2023 00:01
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7de6d78) 84.23% compared to head (b027153) 84.24%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/keywordPreservation.ts 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #864   +/-   ##
=======================================
  Coverage   84.23%   84.24%           
=======================================
  Files         115      115           
  Lines        3604     3606    +2     
  Branches      697      698    +1     
=======================================
+ Hits         3036     3038    +2     
  Misses        324      324           
  Partials      244      244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sergiught
sergiught previously approved these changes Nov 21, 2023
@willvedd willvedd merged commit 9e25d55 into master Nov 22, 2023
7 checks passed
@willvedd willvedd deleted the gh-845-guardian-keyword-preservation branch November 22, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants