Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The branding location changes is a breaking change #941

Closed
6 tasks done
edjanmichiles-toast opened this issue Aug 9, 2024 · 5 comments
Closed
6 tasks done

The branding location changes is a breaking change #941

edjanmichiles-toast opened this issue Aug 9, 2024 · 5 comments
Labels

Comments

@edjanmichiles-toast
Copy link

Checklist

  • I have looked into the README and have not found a suitable solution or answer.
  • I have looked into the documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have upgraded to the latest version of this tool and the issue still persists.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Description

The recent changes to the branding template path have caused a bug in the deploy pipeline: 4b24d78:

2024-08-09T11:42:34.633Z - error: Problem running command import
2024-08-09T11:42:34.634Z - error: Problem deploying branding, Error: Unable to load file /actions-runner/_work/config-customer-authentication/config-customer-authentication/branding_templates/universal_login.html due to Error: ENOENT: no such file or directory, access '/actions-runner/_work/config-customer-authentication/config-customer-authentication/branding_templates/universal_login.html'

Expectation

The deploy to work as expected

Reproduction

Just run the deploy to auth0 using the CLI

Deploy CLI version

7.24.1

Node version

20.x

@gerardino-smg
Copy link

I would like to say this is not a bug but more of a breaking change. In this PR the code that loads the branding template completely ignores the templateDefinition.body and instead expects a file named ${templateDefinition.template}.html.

I'm currently using liquid templates and this pretty much breaks the use for them.

@gerardino-smg
Copy link

Created this PR: #942

@edjanmichiles-toast edjanmichiles-toast changed the title The branding location changes caused a bug The branding location changes is a breaking change Aug 12, 2024
@edjanmichiles-toast
Copy link
Author

I would like to say this is not a bug but more of a breaking change.

I've updated the issue name to reflect it, you're right

@stephenmelrose
Copy link

We've just come across this. Worth reverting the original change and getting a new version out?

kushalshit27 added a commit that referenced this issue Aug 28, 2024
DXCDT-689: Fix branding template body path parsing issue
Issue The branding location changes is a breaking change #941
@kushalshit27
Copy link
Contributor

A fix for this has been provided in 7.24.2. Please update and advise if you have any further issue.
I would appreciate you test this out and if problem still persists, we can re-evaluate. However I'm going to close in the meantime. Thanks for opening this ticket!

kushalshit27 added a commit that referenced this issue Sep 26, 2024
DXCDT-689: Fix branding template body path parsing issue
Issue The branding location changes is a breaking change #941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants