Skip to content

Commit

Permalink
Improvement and fix delay issue in Scim Handler (#933)
Browse files Browse the repository at this point in the history
* Reduce the delay while performing SCIM operations

* Suppressing the frequent warning messages | Optimizing 'applyScimConfiguration'

* fixing indentation

* Fix tab-space inconsistency

* Adding unit tests

* Fixing linting errors

* Adding more unit tests

* Bump chai from 4.4.1 to 4.5.0 (#932)

Bumps [chai](https://github.com/chaijs/chai) from 4.4.1 to 4.5.0.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](chaijs/chai@v4.4.1...v4.5.0)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update codeowner file with new GitHub team name (#931)

Co-authored-by: KunalOfficial <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: stevenwong-okta <[email protected]>
Co-authored-by: KunalOfficial <[email protected]>
  • Loading branch information
4 people authored and kushalshit27 committed Sep 26, 2024
1 parent c28b94f commit 6ab933b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions src/tools/auth0/handlers/connections.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,6 @@ export default class ConnectionsHandler extends DefaultAPIHandler {
config: this.config,
});

// We add the expected changes to the scimHandler so it can track the progress of the SCIM changes.
// This is necessary because import / deploy actions are concurrent and we need to know when all updates are complete.
const { update, create, conflicts } = proposedChangesWithExcludedProperties;
this.scimHandler.expectedChanges = update.length + create.length + conflicts.length;

return proposedChangesWithExcludedProperties;
}

Expand Down
1 change: 0 additions & 1 deletion test/tools/auth0/handlers/scimHandler.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ describe('ScimHandler', () => {
handler.getScimConfiguration = sinon.stub().rejects(new Error('Unexpected error'));
await expect(handler.createIdMap(connections)).to.be.rejectedWith('Unexpected error');
});
});

describe('applyScimConfiguration', () => {
it('should apply SCIM configuration to SCIM connections', async () => {
Expand Down

0 comments on commit 6ab933b

Please sign in to comment.