Test/release process #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurivus-ph
force-pushed
the
test/release-process
branch
from
bf14be7
to
a77ecd1
Compare
aurivus-ph
force-pushed
the
test/release-process
branch
from
6437012
to
b0ce9a7
Compare
aurivus-ph
force-pushed
the
test/release-process
branch
from
3f43250
to
f92a199
Compare
jwiggins
reviewed
Jan 20, 2023
Comment on lines
+4
to
+18
| curl -L "https://downloads.sourceforge.net/project/libpng/libpng16/1.6.37/libpng-1.6.37.tar.gz" -o libpng-1.6.37.tar.gz | ||
| tar zxf libpng-1.6.37.tar.gz | ||
| pushd libpng-1.6.37 | ||
| ./configure | ||
| make -j $(nproc) | ||
| make install | ||
| popd | ||
|
|
||
| URLS=( | ||
| https://www.zlib.net/zlib-1.2.11.tar.gz | ||
| https://downloads.sourceforge.net/project/libpng/libpng16/1.6.37/libpng-1.6.37.tar.gz | ||
| https://download.savannah.gnu.org/releases/freetype/freetype-2.10.4.tar.gz | ||
| https://github.com/harfbuzz/harfbuzz/archive/2.6.4.tar.gz | ||
| ) | ||
| curl -L "https://download.savannah.gnu.org/releases/freetype/freetype-2.12.1.tar.gz" -o freetype-2.12.1.tar.gz | ||
| tar zxf freetype-2.12.1.tar.gz | ||
| pushd freetype-2.12.1 | ||
| ./configure | ||
| make -j $(nproc) | ||
| make install | ||
| popd |
There was a problem hiding this comment.
Yeah. Sometimes doing the simplest thing is the best. DRY was not helping before 😄
jwiggins
reviewed
Jan 20, 2023
Comment on lines
+24
to
+25
| # missing macro in the locally installed automake | ||
| cp /usr/share/aclocal/pkg.m4 /usr/local/share/aclocal |
There was a problem hiding this comment.
Should this be relayed upstream to RalfG/python-wheels-manylinux-build?
There was a problem hiding this comment.
This seems to be a known issue in the base manylinux image: pypa/manylinux#731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.