Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Sandstorm version #695

Open
wants to merge 1 commit into
base: sandstorm
Choose a base branch
from

Conversation

ocdtrekkie
Copy link

This is on the experimental market at https://apps.sandstorm.io/app/a0n6hwm32zjsrzes8gnjg734dh6jwt7x83xdgytspe761pe2asw0?experimental=true

I did not update the "Packaged by" field in this case, but I also did no real changes either. The package drops a massive number of files. I am guessing it is something about not including dev dependencies that previous versions of this package did? It seems to work, but we should extensively test this package before releasing it to everyone.

@ocdtrekkie
Copy link
Author

Looking at the changelog, I am even more confused. SocialCalc is missing. Why does the app work at all without that? But it seems to!

@ocdtrekkie
Copy link
Author

ocdtrekkie commented Dec 13, 2019

Example of one of the debug log errors I am seeing at times:

TypeError: X.utils[("sheet_to_" + t)] is not a function at /node_modules/j/j.js:210:39 at Array.forEach (<anonymous>:null:null) at Object.to_socialcalc (/node_modules/j/j.js:206:23) at IncomingMessage.<anonymous> (/main.js:487:34) at emitNone (events.js:106:13) at IncomingMessage.emit (events.js:208:7) at endReadableNT (streamreadable.js:1064:12) at combinedTickCallback (internal/process/nexttick.js:138:11) at process.tickCallback (internal/process/nexttick.js:180:9)

It should be noted that the commit in the Sandstorm branch pertaining to #694 was included in this build.

@orblivion
Copy link

SocialCalc is missing

It looks like SocialCalc.js was moved, but I still can't find the other files in that package:

https://github.com/audreyt/ethercalc/pull/695/files#diff-b1c216c589cca0ad2d23d5f5479dc67fR415

@ocdtrekkie
Copy link
Author

@orblivion If the app doesn't need any other files in the package to run, it wouldn't include them in sandstorm-files.list.

Now we know for sure that the log error I was seeing is from #694, and it has an associated solution, so I would definitely want to get that fix in before releasing an updated package to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants