-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an exact search mode #1660
Conversation
I'd be happy to change fulltext to be this behaviour to be honest. At this point I'd rather not add any new search modes unless they're sufficiently different. |
Do you want to rename "fulltext" to "exact" or "substr" for the change? |
This pull request has been mentioned on Atuin Community. There might be relevant details there: https://forum.atuin.sh/t/search-output-order-is-not-what-i-expected/108/4 |
I think keep it as fulltext - with this change we're likely to break the installs for anyone currently using fulltext. Or at the very least alias it so that the config still works OK I have absolutely no idea how many people use it though, so we shall have to see if this change is well accepted or not. |
I failed to add an alias due to mehcode/config-rs#502. |
This pull request has been mentioned on Atuin Community. There might be relevant details there: |
in that case, let's change fulltext to be this behaviour :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
fulltext now searches for independent substrings atuinsh/atuin#1660
This pr adds a new search mode called "exact" as skim calls it, in which the query are matched as substrings of the target. In this way, there are much fewer results than the so-called fuzzy search mode, thus provide more relevant results as long as the query is correct.
I usually can't relate fuzzy results to my queries, so I always use this kind of substring match. There is also a full text search mode, which I find less useful as only one substring can be provided.
Checks