Merge pull request #6 from atmina/nested-optional-nullable

feat: allow drilling through optional and nullable
atmina · Feb 9, 2024 · 972a23d · 972a23d
2 parents 3084bce + 050e973
commit 972a23d
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@atmina/formbuilder",
-  "version": "0.0.6",
+  "version": "0.0.7",
   "description": "A strongly-typed alternative API for React Hook Form.",
   "source": "src/index.ts",
   "main": "lib/index.js",

diff --git a/src/formbuilder.tsx b/src/formbuilder.tsx
@@ -81,7 +81,9 @@ export type FormBuilder<T> = FormBuilderRegisterFn<T> & {
         ): $UseFieldArrayReturn<TItem>;
       }
     : {
-        [K in Exclude<keyof T, `${"__"}${string}`>]-?: FormBuilder<T[K]>;
+        [K in Exclude<keyof T, `${"__"}${string}`>]-?: FormBuilder<
+          T[K] extends Primitive ? T[K] : NonNullable<T[K]>
+        >;
       });
 
 /*

diff --git a/src/types.test.tsx b/src/types.test.tsx
@@ -38,6 +38,14 @@ describe("Types", () => {
       FormBuilder<{ foo?: string }>
     >();
 
+    // Nested optional
+    type NestedOptional = FormBuilder<{
+      foo?: { bar?: { baz?: string } };
+    }>;
+    expectTypeOf<NestedOptional["foo"]["bar"]["baz"]>().toMatchTypeOf<
+      FormBuilder<string>
+    >();
+
     // Nullable
     expectTypeOf<FormBuilder<string | null>>().toMatchTypeOf<
       FormBuilder<string>
@@ -46,6 +54,14 @@ describe("Types", () => {
       FormBuilder<string | null>
     >();
 
+    // Nested nullable
+    type NestedNull = FormBuilder<{
+      foo: { bar: { baz: string | null } | null } | null;
+    }>;
+    expectTypeOf<NestedNull["foo"]["bar"]["baz"]>().toMatchTypeOf<
+      FormBuilder<string | null>
+    >();
+
     // Undefined
     expectTypeOf<FormBuilder<string | undefined>>().toMatchTypeOf<
       FormBuilder<string>