Add tests for remaining transforms with defer #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/transforms/DeferredDeepRenameTestSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/transforms/RenamedTypeIsDeferredTestSnapshot.kt
felipe-gdr
requested changes
Sep 16, 2024
...phql/nadel/tests/next/fixtures/defer/transforms/DeferWithTransformThrowsErrorTestSnapshot.kt
Show resolved
Hide resolved
...n/graphql/nadel/tests/next/fixtures/defer/transforms/DeferredRenamedInputTypeTestSnapshot.kt
Show resolved
Hide resolved
| result = """ | ||
| | { | ||
| | "data": { | ||
| | "aErrors": {} |
There was a problem hiding this comment.
There's not incremental data in the assertion here as well.
There was a problem hiding this comment.
In this test, there is not supposed to be incremental data, because there is no data in the aErrors field.
This test is to ensure that the BError type does not get returned in the aErrors field
felipe-gdr
requested changes
Oct 3, 2024
| | query (${'$'}v0: PathType!) { | ||
| | me { | ||
| | profilePicture { | ||
| | path(type: ${'$'}v0) |
There was a problem hiding this comment.
Why is @path not being deferred?
| service = "A", | ||
| query = """ | ||
| | { | ||
| | aErrors { |
There was a problem hiding this comment.
I'm confused by this one... What deferred behaviour are we testing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding defer test for the remaining transforms: