Update tests to all vars #419
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
requested review from
bbakerman,
faizan-siddiqui,
dondonz,
russellyou and
temaEmelyan
gnawf
force-pushed
the
update-tests-all-vars
branch
from
75ab698
to
4a338e9
Compare
gnawf
force-pushed
the
update-tests-all-vars
branch
from
fcba254
to
384d4a2
Compare
gnawf
force-pushed
the
update-tests-all-vars
branch
from
384d4a2
to
310bc59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #418 to feed all the queries through
ExecutableNormalizedOperationFactoryand then dump the updated queries back out to use all variables.Not sure when we should merge this, I don't think we'll be deploying this feature flag soon due to conflicts in input types we found… Leaving it as as draft for now.