Validate webhook after auth flow #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeni
approved these changes
Aug 2, 2023
kbielaski
reviewed
Aug 2, 2023
| try { | ||
| const connectedGroups = await getConnectedGroups(); | ||
|
|
||
| if (connectedGroups.length) { | ||
| await setupAndValidateWebhook(connectedGroups[0].id); |
There was a problem hiding this comment.
How does this change the current implementation? It looks like it doesn't throw currently, so if the webhook is valid or invalid, would the behavior here change?
There was a problem hiding this comment.
We have checked that webhook exists on the GitLab side and re-set up if the webhook was deleted manually. We have the same behavior on GitHub integration. Gitlab support only manually checks the webhook health
PatrickAtlassian
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added webhook handling after auth flow for checking if webhook already exists on the Gitlab side. Also, fixed the issue with the disconnect process if the webhook was manually deleted on the Gitlab side.
Checklist
Please ensure that each of these items has been addressed: