Replace all promise.All with promise.allSettled #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| await Promise.all(groupIds.map((groupId) => disconnectGroup(groupId, cloudId, forgeAppId))); | ||
| const groupIds = await getGroupIds(); | ||
|
|
||
| const result = await Promise.allSettled(groupIds.map((groupId) => disconnectGroup(groupId, cloudId, forgeAppId))); |
There was a problem hiding this comment.
Nit: I'd recommend to call these results since it's a collection.
| @@ -3,6 +3,7 @@ import { getTrackingBranchName } from '../../../services/get-tracking-branch'; | |||
| import { MergeRequestEvent } from '../../../types'; | |||
| import { insertMetricValues } from '../../../services/insert-metric-values'; | |||
| import { getMRCycleTime, getOpenMergeRequestsCount } from '../../../services/compute-event-and-metrics'; | |||
| import { ALL_SETTLED_STATUS, getFormattedErrors } from '../../../utils/promise-allsettled-helpers'; | |||
There was a problem hiding this comment.
Good idea extracting these statuses to a constant.
|
|
||
| const promisesResponse = await Promise.all(getDeploymentsPromises); |
There was a problem hiding this comment.
A single error here would have bubbled up. It looks like the new code is silently catching errors and returning an empty array. Do we want to change that behavior?
There was a problem hiding this comment.
Yeah, maybe better throw error in catch block, or remove try catch, because getDeploymentAfter28Days is used in hasDeploymentAfter28Days, and this method also is called in Promise.allSettled that is in try catch block. But the better option it's remove try catch block to stay the same logic
eserranovalle
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced all
Promise.allwithPromise.allSettledChecklist
Please ensure that each of these items has been addressed: