Change UI for gitlab import so select button does not jump out of screen #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…button as disabled button for now
…f there is no more pages to load
|
My feedback for this PR is pretty much the same as the Bitbucket one |
svankayalapati-atlassian
requested review from
PatrickAtlassian and
ttadej-atlassian
| <LoadingButton | ||
| appearance='primary' | ||
| isDisabled={selectedProjects.length === 0} | ||
| onClick={() => handleNavigateToScreen()} |
There was a problem hiding this comment.
nit; this and the other click handler can be onClick={handleNavigateToScreen}
this is a good habit because it doesn't create an anonymous function on every render
ttadej-atlassian
approved these changes
Sep 9, 2024
PatrickAtlassian
approved these changes
Sep 10, 2024
…-button-does-not-jump-out-of-screen Signed-off-by: svankayalapati-atlassian <[email protected]>
PatrickAtlassian
approved these changes
Sep 10, 2024
…-button-does-not-jump-out-of-screen Signed-off-by: svankayalapati-atlassian <[email protected]>
…-button-does-not-jump-out-of-screen Signed-off-by: svankayalapati-atlassian <[email protected]>
svankayalapati-atlassian
requested review from
PatrickAtlassian and
ttadej-atlassian
ttadej-atlassian
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I moved the selected repos message to the bottom in line with the “Load More” and “Select/Cancel” buttons. I adjusted the height of the table to 65vh (not 70vh) since the header “Select repositories” is slightly bigger than how it is for the Bitbucket import page.
Demo: https://www.loom.com/share/fa31cbfed1144b6180fc7d6068318312?sid=6819833e-dc33-49dc-ae08-d8b41dd21bb7
Checklist
Please ensure that each of these items has been addressed: