Adding conda image to docker registry and CI fix #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moving environment.yml for binder Thanks to the friendly help over here: https://discourse.jupyter.org/t/binder-spawn-failed/27538/3 * Adding aiohttp In this notebook: https://github.com/atlas-outreach-data-tools/notebooks-collection-opendata/blob/master/13-TeV-examples/uproot_python/HZZAnalysis.ipynb We require aiohttp and say that the install lines aren't necessary on mybinder, so we should make sure the package is included in our setup. --------- Co-authored-by: Zach Marshall <[email protected]>
added 15 commits
August 14, 2024 08:34
added 2 commits
August 15, 2024 11:31
Soap2G
added
enhancement
Soap2G
commented
Aug 15, 2024
Soap2G
changed the title
|
Added also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56
Update of the Docker image
Image was updated to build a venv on top of the
environment.ymlfile.Update of the
environment.ymlfileRelated to #52
File was updated including a few missing dependencies and adding fixed versions for preservation:
Update of the main pipeline
Related to #51
Now the check of all the notebooks triggers on pushes to main, and not on single commits.