-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl. response using PSR-7 interface #1706
Merged
Merged
Changes from 1 commit
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
7fd95be
Add nyholm/psr7 for default response and laminas-httphandlerunner as …
abbadon1334 6aa0564
Implemented Psr7 response in App::run() & App::terminate() not SSE
abbadon1334 a28abe4
Raise visibility of Response, which is immutable so no worry for muta…
abbadon1334 7e074be
Merge branch 'develop' of https://github.com/atk4/ui into feature/add…
abbadon1334 37f9700
Removed uneeded comments
abbadon1334 41bb064
Removed laminas-httphandlerrunner refactor App::emitResponse()
abbadon1334 39c2cda
Use header_sent() to strict check for unexcepted output
abbadon1334 cb3b2f8
Emit directly response before Exit
abbadon1334 cb56315
Merge branch 'develop' of https://github.com/atk4/ui into develop
abbadon1334 beb149f
Merge branch 'develop' into feature/add-psr7
abbadon1334 a15b54a
CleanUp code
abbadon1334 52d3b69
Add request changes
abbadon1334 ec35302
Fix Guzzle response->getBody()->getContents() gives empty string
abbadon1334 f7f6f95
Add Sse support
abbadon1334 98eda01
Fix CodeStyle
abbadon1334 91752b7
Fix LateError
abbadon1334 2fc8036
Revert $isCli check for headers
abbadon1334 101325f
Merge remote-tracking branch 'origin/develop' into feature/add-psr7
abbadon1334 79212e7
Revert changes in Tests
abbadon1334 e42c267
Reworked code after merge
abbadon1334 ef2f475
Fix CodeStyle
abbadon1334 653a34b
Removed pattern in PHPStan not present anymore
abbadon1334 d817b6a
Added check same response in Tests
abbadon1334 ae6a852
Add rule to phpstan for App::$responseClass
abbadon1334 eefffe2
Moved $app exception not raise in DemosTest::createTestingApp() (PHPS…
abbadon1334 94e4aca
Fix CodeStyle
abbadon1334 8e07e8c
Separate response building from emitting
abbadon1334 ce6c0ce
Fix Typo
abbadon1334 45cf56e
Add some comments to explain better Sse Flow
abbadon1334 f53e958
Move back in try/catch $this->createTestingApp()
abbadon1334 7785073
Fix phpstan error, hope for codestyle
abbadon1334 8f94a2f
Fix phpstan
abbadon1334 4c1a5fb
Merge branch 'develop' of https://github.com/atk4/ui into feature/add…
abbadon1334 55fafcc
Removed App $responseClass
abbadon1334 a75b111
Align composer require-release to require
abbadon1334 0f782ec
Add composer nyholm/psr7-server
abbadon1334 d132293
Inject response and request on private properties
abbadon1334 37b98d0
Fix Request
abbadon1334 b1521fa
Simplify headers management using response
abbadon1334 206800d
Simplify getRequestUrl using Request
abbadon1334 b8c03f0
Add some tests and comments
abbadon1334 c340087
Removed normalizeHeaders + Tests (Response do it internally)
abbadon1334 cc0b7d0
Clean up
abbadon1334 8b71aa3
Fix phpstan error
abbadon1334 b074150
Fix unit test errors
abbadon1334 a4bbf53
CleanUp
abbadon1334 04c430d
Fix no assertion for testDemoLateOutputError
abbadon1334 ef9dee6
Remove unused normalizeHeaders
abbadon1334 7a9b203
Removed Test LateOutputError assert StatusCode = 500
abbadon1334 6fa75c6
Try Fix PHPUnit test for LateOutputError (cannot recreate locally)
abbadon1334 8cdd09a
Fix PHPUnit test for LateOutputError
abbadon1334 959dbc7
Try Fix MemLeak in UnitTest 8.1 for Psr7 response
abbadon1334 8aa9cf9
Try Fix MemLeak in UnitTest 8.1 for Psr7 response
abbadon1334 a148bc4
Fix UnitTest use App::run in place of App::terminateHtml, due to stra…
abbadon1334 0b24853
Fix typo
abbadon1334 0d9bd12
Fix style
abbadon1334 608acf2
Remove Duplicates
abbadon1334 09ec6e1
Add App::getRequest() + method helpers for _GET _POST
abbadon1334 dc943af
Removed gc_collect_cycles()
abbadon1334 0e66555
Merge remote-tracking branch 'origin/develop' into feature/add-psr7
abbadon1334 8511308
Fix $response->getBody()->getContents() not returning string
abbadon1334 5ee20b1
Delete outputErrors.php
mvorisek 35e9f13
Merge branch 'develop' into feature/add-psr7
mvorisek 4dd4fc0
Merge branch 'develop' into feature/add-psr7
mvorisek ebf8084
fix 500 with unexpected flush
mvorisek 0f7813d
fix stan
mvorisek cd3e806
Merge branch 'develop' into feature/add-psr7
mvorisek db7267d
fix rewinding and assert no direct output
mvorisek 5bcf3bd
Merge branch 'develop' into feature/add-psr7
mvorisek 9fed29c
Merge branch 'develop' into feature/add-psr7
mvorisek 6785c7d
Merge branch 'develop' into feature/add-psr7
mvorisek aa40f03
Merge branch 'develop' into feature/add-psr7
mvorisek 29889e5
Merge branch 'develop' into feature/add-psr7
mvorisek acf944b
DEBUG hotfix tests after develop merge
mvorisek 8eb3401
Merge branch 'develop' into feature/add-psr7
mvorisek 9f082cb
Merge branch 'develop' into feature/add-psr7
mvorisek 74c5ab2
Merge branch 'develop' into feature/add-psr7
mvorisek 005cb91
remove todo in app
mvorisek 73822e7
Merge branch 'develop' into feature/add-psr7
mvorisek 8b74105
Merge branch 'develop' into feature/add-psr7
mvorisek 970511d
Merge branch 'develop' into feature/add-psr7
mvorisek ee52c89
DEBUG Revert "remove todo in app"
mvorisek 0647b73
REVERT ALL
mvorisek dfbce1a
add PSR7 request/response create
mvorisek fb09616
refactor App::getRequestUrl() to use PSR7 request as source
mvorisek 93bb214
remove App::normalizeHeaders - recheck after finish
mvorisek 1b992f9
remove $headersNew param from App::outputResponseUnsafe
mvorisek 11e2b4d
add request/response getters
mvorisek 5958bd9
drop magic App::HEADER_STATUS_CODE header support
mvorisek 91e12db
drop $headers param from App::outputResponse{Html,Json}
mvorisek b353374
replace App::$_sentHeaders with PSR7 response data
mvorisek 60e12f0
replace echo with App::emitResponse()
mvorisek 407e6b3
fix App::outputLateOutputError()
mvorisek 40a03e1
assert if headers can be set early
mvorisek d7faa9c
fix SSE
mvorisek 92126f3
fix typo
mvorisek cb4b48d
drop internal App::outputResponseRaw
mvorisek 634063c
drop unused request getters
mvorisek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be reintroduced in #2009