Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 add support for files with no extension #577

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olirwin
Copy link

@olirwin olirwin commented Mar 6, 2023

Description

Updated the way the key is computed to allow for files without an extension to get icons.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.03 🎉

Comparison is base (5e0b25a) 90.86% compared to head (fdcd93c) 91.89%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   90.86%   91.89%   +1.03%     
==========================================
  Files           8        8              
  Lines         580      617      +37     
==========================================
+ Hits          527      567      +40     
+ Misses         53       50       -3     
Impacted Files Coverage Δ
lib/colorls/core.rb 92.80% <100.00%> (+2.00%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@avdv
Copy link
Collaborator

avdv commented Apr 24, 2023

Thank you @olirwin!

The tests failed, can you fix them?

@avdv avdv mentioned this pull request Apr 30, 2023
Should remove warnings in tests due to double quoted strings
@olirwin
Copy link
Author

olirwin commented May 1, 2023

Thank you @olirwin!

The tests failed, can you fix them?

Fixed as much as I could understand (there were 2 failing tests, one due to linter warnings, the other to test coverage).
I am not in a position to write tests for this change in code.

The other tests were just being auto cancelled.

@dmitrykok
Copy link

dmitrykok commented Apr 29, 2024

Solved this: add support for files with no extension #577
and:
Fixes Icons for files without extenstions #459
Relates to Icons for file with only one extension #469

tests:

bundle exec rubocop
bundle exec rspec
test/run

finished OK

Here you can see dot-files with icons and file without extension with icon, and also can be file only from dots:
image

how to assign it to me ? and make me permission to commit branch and PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons for files without extenstions
4 participants