Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add '-L' option #565

Merged
merged 3 commits into from
Mar 16, 2023
Merged

add '-L' option #565

merged 3 commits into from
Mar 16, 2023

Conversation

t-mangoe
Copy link
Contributor

@t-mangoe t-mangoe commented Jan 7, 2023

Description

Thanks for contributing this Pull Request. Add a brief description of what this Pull Request does. Do tag the relevant issue(s) and PR(s) below. If required, add some screenshot(s) to support your changes.

I added -H -L option.
This PR closes the #515 issue.

  • Relevant Issues : Target size from Symbolic link ls -lH #515
  • Relevant PRs : (none)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Base: 90.86% // Head: 91.79% // Increases project coverage by +0.93% 🎉

Coverage data is based on head (cbad757) compared to base (95f4921).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
+ Coverage   90.86%   91.79%   +0.93%     
==========================================
  Files           8        8              
  Lines         580      597      +17     
==========================================
+ Hits          527      548      +21     
+ Misses         53       49       -4     
Impacted Files Coverage Δ
lib/colorls/core.rb 92.66% <100.00%> (+1.86%) ⬆️
lib/colorls/flags.rb 89.47% <100.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@errantepiphany
Copy link

Would love to see this get merged! :)

Copy link
Collaborator

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.

IMO, this does not implement the -H option, actually it implements the -L option:

-L, --dereference
when showing file information for a symbolic link, show information for the file the link references rather than for the link itself

Could you change the option and help text accordingly, please?!

@t-mangoe
Copy link
Contributor Author

@avdv
Thank you for comment!
I have changed the option name. Is it necessary to change the help text?

Copy link
Collaborator

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help text is actually fine, thank you @t-mangoe!

@avdv avdv changed the title add '-H' option add '-L' option Mar 16, 2023
@avdv avdv merged commit be24457 into athityakumar:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants