Merge pull request #52 from atcoder/patch/issue51

fix #51: add assert for mcf_graph.add_edge
atcoder · Sep 22, 2020 · dd53a96 · dd53a96
2 parents 7feec57 + 090a939
commit dd53a96
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/atcoder/mincostflow.hpp b/atcoder/mincostflow.hpp
@@ -17,6 +17,8 @@ template <class Cap, class Cost> struct mcf_graph {
     int add_edge(int from, int to, Cap cap, Cost cost) {
         assert(0 <= from && from < _n);
         assert(0 <= to && to < _n);
+        assert(0 <= cap);
+        assert(0 <= cost);
         int m = int(pos.size());
         pos.push_back({from, int(g[from].size())});
         int from_id = int(g[from].size());

diff --git a/test/unittest/mincostflow_test.cpp b/test/unittest/mincostflow_test.cpp
@@ -87,4 +87,11 @@ TEST(MincostflowTest, SameCostPaths) {
     ASSERT_EQ(2, g.add_edge(0, 2, 2, 1));
     auto expected = std::vector<std::pair<int, int>>{{0, 0}, {3, 3}};
     ASSERT_EQ(expected, g.slope(0, 2));
-}
+}
+
+TEST(MincostflowTest, Invalid) {
+    mcf_graph<int, int> g(2);
+    // https://github.com/atcoder/ac-library/issues/51
+    EXPECT_DEATH(g.add_edge(0, 0, -1, 0), ".*");
+    EXPECT_DEATH(g.add_edge(0, 0, 0, -1), ".*");
+}