fix: add go omitempty json tag (#2004)

asyncapi · May 21, 2024 · 4a296b7 · 4a296b7
1 parent a994e02
commit 4a296b7
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 9 deletions.
diff --git a/examples/go-json-tags/__snapshots__/index.spec.ts.snap b/examples/go-json-tags/__snapshots__/index.spec.ts.snap
@@ -4,8 +4,8 @@ exports[`Should be able to render json-tags in struct and should log expected ou
 Array [
   "// Root represents a Root model.
 type Root struct {
-  Cities *Cities \`json:\\"cities\\"\`
-  Options *Options \`json:\\"options\\"\`
+  Cities *Cities \`json:\\"cities, omitempty\\"\`
+  Options *Options \`json:\\"options, omitempty\\"\`
 }",
 ]
 `;

diff --git a/modelina-cli/package-lock.json b/modelina-cli/package-lock.json
diff --git a/src/generators/go/presets/CommonPreset.ts b/src/generators/go/presets/CommonPreset.ts
@@ -21,7 +21,7 @@ function renderJSONTag({
   ) {
     return `json:"-"`;
   }
-  return `json:"${field.unconstrainedPropertyName}"`;
+  return `json:"${field.unconstrainedPropertyName}, omitempty"`;
 }
 
 function renderMarshallingFunctions({

diff --git a/test/generators/go/presets/CommonPreset.spec.ts b/test/generators/go/presets/CommonPreset.spec.ts
@@ -7,7 +7,9 @@ import {
 describe('GO_COMMON_PRESET', () => {
   let generator: GoGenerator;
   beforeEach(() => {
-    const options: GoCommonPresetOptions = { addJsonTag: true };
+    const options: GoCommonPresetOptions = {
+      addJsonTag: true
+    };
     generator = new GoGenerator({
       presets: [{ preset: GO_COMMON_PRESET, options }]
     });

diff --git a/test/generators/go/presets/__snapshots__/CommonPreset.spec.ts.snap b/test/generators/go/presets/__snapshots__/CommonPreset.spec.ts.snap
@@ -3,9 +3,9 @@
 exports[`GO_COMMON_PRESET should render json tags for structs 1`] = `
 "// Root represents a Root model.
 type Root struct {
-  StringProp string \`json:\\"stringProp\\"\`
-  NumberProp float64 \`json:\\"numberProp\\"\`
-  BooleanProp bool \`json:\\"booleanProp\\"\`
+  StringProp string \`json:\\"stringProp, omitempty\\"\`
+  NumberProp float64 \`json:\\"numberProp, omitempty\\"\`
+  BooleanProp bool \`json:\\"booleanProp, omitempty\\"\`
 }"
 `;