Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: querying tool for the Planetary Ring Node #2358

Merged
merged 25 commits into from
Jan 5, 2023
Merged

ENH: querying tool for the Planetary Ring Node #2358

merged 25 commits into from
Jan 5, 2023

Commits on Jan 5, 2023

  1. started building infrastructure for solarsystem.pds.RingNode

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    6722d7a View commit details
    Browse the repository at this point in the history

  2. minimum working example. parses basic query for all six targets

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    d96fa2e View commit details
    Browse the repository at this point in the history

  3. allowed option to pass observatory coordinates

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    21e146c View commit details
    Browse the repository at this point in the history

  4. added some tests

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    ae97eb9 View commit details
    Browse the repository at this point in the history

  5. attempted to fix all pep8 problems

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    b7d2751 View commit details
    Browse the repository at this point in the history

  6. added units, some fixes suggested by mkelley

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    d4b1f02 View commit details
    Browse the repository at this point in the history

  7. added offline test

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    72a34be View commit details
    Browse the repository at this point in the history

  8. small fixes to tests, improved documentation

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    2dfa100 View commit details
    Browse the repository at this point in the history

  9. added test for Pluto, wrote an rst file

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    c8f7b4c View commit details
    Browse the repository at this point in the history

  10. small fixes as suggested by mkelley, and trying to fix docs

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    44dc8f7 View commit details
    Browse the repository at this point in the history

  11. tests for Saturn, Neptune special cases

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    d6e7edf View commit details
    Browse the repository at this point in the history

  12. made (hopefully) all changes from code review

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    eb6a179 View commit details
    Browse the repository at this point in the history

  13. made all changes suggested by @eerovaher

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    b884513 View commit details
    Browse the repository at this point in the history

  14. attempted fix to AttributeError: 'RingNodeClass' object has no attrib… 

    …ute '_last_query'
    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    1d2621d View commit details
    Browse the repository at this point in the history

  15. complying with template in pull request #2341

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    95c9570 View commit details
    Browse the repository at this point in the history

  16. fixes suggested by @eerovaher

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    66c87f2 View commit details
    Browse the repository at this point in the history

  17. changes suggested by @bsipocz

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    65f5167 View commit details
    Browse the repository at this point in the history

  18. made adding units with QTable back-compatible with 3.7

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    3c92254 View commit details
    Browse the repository at this point in the history

  19. fixing oldest dependencies table read duplicate column error

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    550bd95 View commit details
    Browse the repository at this point in the history

  20. added support for jwst

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    a33753b View commit details
    Browse the repository at this point in the history

  21. forgot to test before push 🤦

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    9570932 View commit details
    Browse the repository at this point in the history

  22. changes suggested by @bsipocz, most importantly adding platform-indep… 

    …endent newline handling
    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    55cea03 View commit details
    Browse the repository at this point in the history

  23. changelog entry

    @emolter @bsipocz
    emolter authored and bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    6cc3749 View commit details
    Browse the repository at this point in the history

  24. Addressing final review items

    @bsipocz
    bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    6448ab8 View commit details
    Browse the repository at this point in the history

  25. Fix windows parsing

    @bsipocz
    bsipocz committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    51ead5f View commit details
    Browse the repository at this point in the history