Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable do_xcom_push param in KPO example #1249

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

pankajastro
Copy link
Contributor

In our KPO example test, we write some dummy data at path /airflow/xcom/return.json
The intention of doing this would be probably to push this data in xcom
but it does not push since do_xcom_push is false.
so either we should set do_xcom_push to true or remove 'echo \'{"message": "good afternoon!"}\' > /airflow/xcom/return.json'

@pankajastro pankajastro marked this pull request as ready for review July 18, 2023 20:17
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (05e551b) 98.58% compared to head (527fa5c) 98.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1249   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          90       90           
  Lines        5390     5390           
=======================================
  Hits         5314     5314           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pankajastro pankajastro merged commit e10d5b3 into main Jul 19, 2023
2 checks passed
@pankajastro pankajastro deleted the enable_do_xcom_push_in_kpo branch July 19, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants