style: fix mypy failure #1244
Merged
style: fix mypy failure #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
requested review from
phanikumv,
pankajastro,
pankajkoti,
sunank200 and
utkarsharma2
as code owners
pankajkoti
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Looks like we do not have all changes here that we have in #1241
pankajkoti
approved these changes
Jul 13, 2023
|
@pankajkoti Thanks for reminding me! Messed it up during cherry-pick 🤦♂️ |
pankajastro
reviewed
Jul 13, 2023
| delimiter: str = "/", | ||
| **kwargs: Any, | ||
| ) -> List[BlobProperties]: |
There was a problem hiding this comment.
I think we should inline this with apache/airflow#32545 changes
There was a problem hiding this comment.
Sure! I've updated it. Could you please check again? Thanks!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1244 +/- ##
==========================================
- Coverage 98.58% 98.40% -0.19%
==========================================
Files 90 90
Lines 5389 5383 -6
==========================================
- Hits 5313 5297 -16
- Misses 76 86 +10
☔ View full report in Codecov by Sentry. |
|
as apache/airflow#32568 is merged, I'll merge this one now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1241
We'll need to wait for the release of apache/airflow#32568