Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actionlint #1243

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Add actionlint #1243

merged 4 commits into from
Jul 13, 2023

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Jul 13, 2023

Failures due to #1240 changes (fixed in #1242) can be detected through actionlint. Thus, adding this lint for preventing this kind of error in the future

Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not understand exactly on what are we checking with actionlint here. Can you please help me understand?

@Lee-W
Copy link
Contributor Author

Lee-W commented Jul 13, 2023

I did not understand exactly on what are we checking with actionlint here. Can you please help me understand?

yamls inside .github/workflows

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d7a7b32) 98.58% compared to head (510b3f4) 98.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1243   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          90       90           
  Lines        5389     5389           
=======================================
  Hits         5313     5313           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pankajkoti
Copy link
Collaborator

I did not understand exactly on what are we checking with actionlint here. Can you please help me understand?

yamls inside .github/workflows

and what do we check for exactly in those yamls?

@pankajkoti
Copy link
Collaborator

Is it that we have the template yaml that we use and it will report for missing secrets that need to be passed from other yamls that use the template YAML?

@Lee-W
Copy link
Contributor Author

Lee-W commented Jul 13, 2023

Is it that we have the template yaml that we use and it will report for missing secrets that need to be passed from other yamls that use the template YAML?

Including but not limited to this check, the check you mentioned is https://github.com/rhysd/actionlint/blob/main/docs/checks.md#check-inputs-and-secrets-in-workflow-call, but it can also check a bunch of potential failures

@Lee-W Lee-W merged commit 3c032c9 into main Jul 13, 2023
2 checks passed
@Lee-W Lee-W deleted the add-actionlint branch July 13, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants