Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix triggering failure due to astro_cloud subdomain change #1222

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Jun 29, 2023

  • ci(github-actions):
    • fix fix triggering failure due to astro_cloud subdomain change
    • refactor: extract common wait and trigger logic as a reusable workflow

For this workflow to work, we must set the latest subdomain to github secret as ASTRO_SUBDOMAIN. we used to hardcode it in the script, but I think it might be better for use to keep it secret

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (13544fe) 98.58% compared to head (138db80) 98.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1222   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          90       90           
  Lines        5389     5389           
=======================================
  Hits         5313     5313           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a default value for now as we might now have access to secrets? And we can keep changing the default values in our branch

@Lee-W
Copy link
Contributor Author

Lee-W commented Jun 29, 2023

That's something I'd like to discuss as well. I'd opt to keep such a thing secret. As we don't change this value often, I think that should be fine

@Lee-W
Copy link
Contributor Author

Lee-W commented Jun 29, 2023

I'll temporary add the value for testing and drop that commit

@Lee-W Lee-W force-pushed the fix-trigger-failure branch 3 times, most recently from 9391574 to bdb92d9 Compare June 29, 2023 07:12
@Lee-W Lee-W marked this pull request as ready for review June 29, 2023 07:16
@Lee-W Lee-W changed the title ci(github-actions): fix triggering failure due to astro_cloud subdomain change fix triggering failure due to astro_cloud subdomain change Jun 29, 2023
@Lee-W Lee-W merged commit d9b329d into main Jul 1, 2023
@Lee-W Lee-W deleted the fix-trigger-failure branch July 1, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants