-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
deprecate KubernetesPodOperatorAsync (#1465)
Deperecate KubernetesPodOperatorAsync and proxy it to its OSS counterpart. related: #1418 --------- Co-authored-by: Pankaj Koti <[email protected]> Co-authored-by: Pankaj Koti <[email protected]>
- Loading branch information
3 people
authored
Feb 18, 2024
1 parent
671aa93
commit 2555e08
Showing
4 changed files
with
35 additions
and
299 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,163 +1,15 @@ | ||
| from unittest import mock | ||
| from unittest.mock import MagicMock | ||
|
|
||
| import pytest | ||
| from airflow.exceptions import TaskDeferred | ||
| from airflow.providers.cncf.kubernetes.utils.pod_manager import PodLoggingStatus | ||
| from airflow.providers.cncf.kubernetes.operators.pod import KubernetesPodOperator | ||
|
|
||
| from astronomer.providers.cncf.kubernetes.operators.kubernetes_pod import ( | ||
| KubernetesPodOperatorAsync, | ||
| PodNotFoundException, | ||
| ) | ||
| from astronomer.providers.cncf.kubernetes.triggers.wait_container import ( | ||
| PodLaunchTimeoutException, | ||
| ) | ||
| from tests.utils.airflow_util import create_context | ||
|
|
||
| KUBE_POD_MOD = "astronomer.providers.cncf.kubernetes.operators.kubernetes_pod" | ||
|
|
||
|
|
||
| class TestKubernetesPodOperatorAsync: | ||
| def test_raise_for_trigger_status_pending_timeout(self): | ||
| """Assert trigger raise exception in case of timeout""" | ||
| with pytest.raises(PodLaunchTimeoutException): | ||
| KubernetesPodOperatorAsync.raise_for_trigger_status( | ||
| { | ||
| "status": "error", | ||
| "error_type": "PodLaunchTimeoutException", | ||
| "description": "any message", | ||
| } | ||
| ) | ||
|
|
||
| def test_raise_for_trigger_status_done(self): | ||
| """Assert trigger don't raise exception in case of status is done""" | ||
| assert KubernetesPodOperatorAsync.raise_for_trigger_status({"status": "done"}) is None | ||
|
|
||
| @mock.patch("airflow.providers.cncf.kubernetes.operators.kubernetes_pod.KubernetesPodOperator.client") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.cleanup") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.raise_for_trigger_status") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.find_pod") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.await_pod_completion") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.fetch_container_logs") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.hooks.kubernetes.KubernetesHook._get_default_client") | ||
| def test_get_logs_running( | ||
| self, | ||
| mock_get_default_client, | ||
| fetch_container_logs, | ||
| await_pod_completion, | ||
| find_pod, | ||
| raise_for_trigger_status, | ||
| cleanup, | ||
| mock_client, | ||
| ): | ||
| """When logs fetch exits with status running, raise task deferred""" | ||
| pod = MagicMock() | ||
| find_pod.return_value = pod | ||
| op = KubernetesPodOperatorAsync(task_id="test_task", name="test-pod", get_logs=True) | ||
| mock_client.return_value = {} | ||
| context = create_context(op) | ||
| await_pod_completion.return_value = None | ||
| fetch_container_logs.return_value = PodLoggingStatus(True, None) | ||
| with pytest.raises(TaskDeferred): | ||
| op.trigger_reentry(context, None) | ||
| fetch_container_logs.is_called_with(pod, "base") | ||
|
|
||
| @mock.patch("airflow.providers.cncf.kubernetes.operators.kubernetes_pod.KubernetesPodOperator.client") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.cleanup") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.raise_for_trigger_status") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.find_pod") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.await_pod_completion") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.fetch_container_logs") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.hooks.kubernetes.KubernetesHook._get_default_client") | ||
| def test_get_logs_not_running( | ||
| self, | ||
| mock_get_default_client, | ||
| fetch_container_logs, | ||
| await_pod_completion, | ||
| find_pod, | ||
| raise_for_trigger_status, | ||
| cleanup, | ||
| mock_client, | ||
| ): | ||
| pod = MagicMock() | ||
| find_pod.return_value = pod | ||
| mock_client.return_value = {} | ||
| op = KubernetesPodOperatorAsync(task_id="test_task", name="test-pod", get_logs=True) | ||
| context = create_context(op) | ||
| await_pod_completion.return_value = None | ||
| fetch_container_logs.return_value = PodLoggingStatus(False, None) | ||
| op.trigger_reentry(context, None) | ||
| fetch_container_logs.is_called_with(pod, "base") | ||
|
|
||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.cleanup") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.raise_for_trigger_status") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.find_pod") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.await_pod_completion") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.fetch_container_logs") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.hooks.kubernetes.KubernetesHook._get_default_client") | ||
| def test_no_pod( | ||
| self, | ||
| mock_get_default_client, | ||
| fetch_container_logs, | ||
| await_pod_completion, | ||
| find_pod, | ||
| raise_for_trigger_status, | ||
| cleanup, | ||
| ): | ||
| """Assert if pod not found then raise exception""" | ||
| find_pod.return_value = None | ||
| op = KubernetesPodOperatorAsync(task_id="test_task", name="test-pod", get_logs=True) | ||
| context = create_context(op) | ||
| with pytest.raises(PodNotFoundException): | ||
| op.trigger_reentry(context, None) | ||
|
|
||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.cleanup") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.find_pod") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.await_pod_completion") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.fetch_container_logs") | ||
| @mock.patch("airflow.providers.cncf.kubernetes.hooks.kubernetes.KubernetesHook._get_default_client") | ||
| def test_trigger_error( | ||
| self, | ||
| mock_get_default_client, | ||
| fetch_container_logs, | ||
| await_pod_completion, | ||
| find_pod, | ||
| cleanup, | ||
| ): | ||
| """Assert that trigger_reentry raise exception in case of error""" | ||
| find_pod.return_value = MagicMock() | ||
| op = KubernetesPodOperatorAsync(task_id="test_task", name="test-pod", get_logs=True) | ||
| with pytest.raises(PodLaunchTimeoutException): | ||
| context = create_context(op) | ||
| op.trigger_reentry( | ||
| context, | ||
| { | ||
| "status": "error", | ||
| "error_type": "PodLaunchTimeoutException", | ||
| "description": "any message", | ||
| }, | ||
| ) | ||
|
|
||
| def test_defer_with_kwargs(self): | ||
| """Assert that with kwargs throw exception""" | ||
| op = KubernetesPodOperatorAsync(task_id="test_task", name="test-pod", get_logs=True) | ||
| with pytest.raises(ValueError): | ||
| op.defer(kwargs={"timeout": 10}) | ||
|
|
||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.build_pod_request_obj") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.get_or_create_pod") | ||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.defer") | ||
| def test_execute(self, mock_defer, mock_get_or_create_pod, mock_build_pod_request_obj): | ||
| """Assert that execute succeeded""" | ||
| mock_get_or_create_pod.return_value = {} | ||
| mock_build_pod_request_obj.return_value = {} | ||
| mock_defer.return_value = {} | ||
| op = KubernetesPodOperatorAsync(task_id="test_task", name="test-pod", get_logs=True) | ||
| assert op.execute(context=create_context(op)) is None | ||
| def test_init(self): | ||
| task = KubernetesPodOperatorAsync( | ||
| task_id="test_task", name="test-pod", get_logs=True, logging_interval=5 | ||
| ) | ||
|
|
||
| @mock.patch(f"{KUBE_POD_MOD}.KubernetesPodOperatorAsync.trigger_reentry") | ||
| def test_execute_complete(self, mock_trigger_reentry): | ||
| """Assert that execute_complete succeeded""" | ||
| mock_trigger_reentry.return_value = {} | ||
| op = KubernetesPodOperatorAsync(task_id="test_task", name="test-pod", get_logs=True) | ||
| assert op.execute_complete(context=create_context(op), event={}) is None | ||
| assert isinstance(task, KubernetesPodOperator) | ||
| assert task.deferrable is True |