Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor SEP-10 #286

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

chore: refactor SEP-10 #286

wants to merge 5 commits into from

Conversation

charlie-wasp
Copy link
Contributor

No description provided.

@charlie-wasp charlie-wasp self-assigned this Oct 29, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 29, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@nebolsin nebolsin changed the title Refactor SEP-10 chore: refactor SEP-10 Nov 2, 2022
@coveralls
Copy link

coveralls commented Apr 7, 2023 •
edited by coveralls-official bot
Loading

Pull Request Test Coverage Report for Build 6271935013

  • 14 of 15 (93.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 94.551%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdk/lib/stellar/sep10.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 6269750352: 0.03%
Covered Lines: 5184
Relevant Lines: 5360
💛 - Coveralls

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 7, 2023
View reviewed changes
ecosystem/bin/setup
@@ -0,0 +1,8 @@
#!/usr/bin/env bash
set -euo pipefail
IFS=$'\n\t'

Check warning

Code scanning / Semgrep

Semgrep Finding: bash.lang.security.ifs-tampering.ifs-tampering Warning

The special variable IFS affects how splitting takes place when expanding unquoted variables. Don't set it globally. Prefer a dedicated utility such as 'cut' or 'awk' if you need to split input data. If you must use 'read', set IFS locally using e.g. 'IFS="," read -a my_array'.
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 22, 2023
View reviewed changes
ecosystem/README.md

## Contributing

Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/stellar-ecosystem.

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition
ecosystem/README.md

And then execute:

$ bundle install

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when code blocks do not adhere to a given style. Note

[code-block-style] Code blocks should be fenced
ecosystem/README.md

Or install it yourself as:

$ gem install stellar-ecosystem

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when code blocks do not adhere to a given style. Note

[code-block-style] Code blocks should be fenced
ecosystem/CHANGELOG.md

## [0.1.0] - 2022-10-29

- Initial release

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when the spacing between a list item’s bullet and its content violates Note

[list-item-indent] Incorrect list-item indent: add 2 spaces
ecosystem/CHANGELOG.md
@@ -0,0 +1,5 @@
## [Unreleased]

## [0.1.0] - 2022-10-29

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition
ecosystem/CHANGELOG.md
@@ -0,0 +1,5 @@
## [Unreleased]

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition
@codacy-production
Copy link

codacy-production bot commented Sep 22, 2023 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.07% (target: -1.00%) 93.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1db3a01) 2849 2672 93.79%
Head commit (f00a6d6) 2863 (+14) 2687 (+15) 93.85% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#286) 15 14 93.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebolsin nebolsin Awaiting requested review from nebolsin

Assignees

@charlie-wasp charlie-wasp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlie-wasp @coveralls @nebolsin