Refactor CI to remove duplication #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into tk/refactor-ci
20DM
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by our struggles with code duplication in the CI yesterday, I had a go at refactoring the workflows. I've created three jobs in the
CIworkflow.buildjob builds the dependencies (Catch, FFTW, SOPT).docjob builds and deploys the documentationtestjob builds and runs the testsI also cleaned up the matrix a little and re-enabled an OpenMP test on MacOS (it's soo fast 🚀). I'm still unhappy about how the job matrix is duplicated across jobs, and how the
apt/brewinstalls have to be redone. I tried to trim them down to the necessary packages. If you spot any unnecessary ones please remove them 😄Also updated to Ubuntu-22.04 and
gcc-12.