Feature: Add ability to minimize panes on main view #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steezeburger
approved these changes
Aug 14, 2024
| @@ -52,6 +52,7 @@ type NewProcessRunnerOpts struct { | |||
| Env []string | |||
| Args []string | |||
| ReadyCheck *ReadyChecker | |||
| // TODO: add a StartsMinimized bool when TUI config is added | |||
There was a problem hiding this comment.
I agree we need some config for this but I'm not sure this is the correct place. We can pair on this before tui config
There was a problem hiding this comment.
Actually, I guess ProcessRunner is what is passed into ProcessPane, so this is probably the place to put it!
steezeburger
added a commit
that referenced
this pull request
Aug 14, 2024
* main: add ability to minimize panes on main view (#151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in the main view, you can now minimize or maximize any pane by hitting 'm'.
This does not affect the underlying TextView object that displays the logs. Only the Flex item that holds all the panes are affected and this visual change is reflected only when all the panes on the main view are rendered.