Correctly trims values during wheel WHEEL file parsing #7770
+34
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coruscant11
changed the title
Last changes used by mistake == instead of !=. A unit test has been added to validate that we correctly trim values. Also removes the trim of the header name, because if a header contains spaces, the header will be skipped by the mailparse crate in the first place.
Coruscant11
force-pushed
the
fix/wheel-file-trimming
branch
from
a239b78
to
a475475
Compare
charliermarsh
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
My last changes (#6616) used by mistake == instead of !=. 😥 Making values currently never trimmed despite what we wanted.
Values should now be trimmed if needed.
Also removes the trim of the header name, because if a header contains spaces, the header will be skipped by the mailparse crate in the first place.
Test Plan