Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces in path requirements #7767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Sep 28, 2024

Summary

This PR modifies our parsing to allow spaces in URLs. I don't know if this is a correct change... But we now parse URLs until we see:

  • A newline.
  • A semicolon (marker) or hash (comment), preceded by a space. We parse the URL until the last
    non-whitespace character (inclusive).
  • A semicolon (marker) or hash (comment) followed by a space. We treat this as an error, since
    the end of the URL is ambiguous (e.g., https://foo.com; marker) would be a URL that ends in ;).

Closes #6032.

@charliermarsh charliermarsh added the bug Something isn't working label Sep 28, 2024
@charliermarsh charliermarsh marked this pull request as ready for review September 28, 2024 21:23
@charliermarsh charliermarsh force-pushed the charlie/spaces branch 5 times, most recently from 1f0695d to e548c81 Compare September 29, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken path parsing for install spec
1 participant