Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv python install: Detect hard-float support #7725

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

kakkoyun
Copy link
Contributor

@kakkoyun kakkoyun commented Sep 26, 2024

Signed-off-by: Kemal Akkoyun [email protected]

Summary

This pull request fixes #6873 by implementing
a mechanism to detect whether the ARM architecture supports the VFP (Vector Floating Point) hardware,
which is critical for selecting the appropriate libc variant.

The detection is based on reading the flags from /proc/cpuinfo.
Specifically, if the vfp flag is present, the system will use the gnueabihf (hard-float ABI) variant;
if not, it will default to gnueabi (soft-float ABI).

For additional context, see the Debian documentation on the ARM Hard Float Port.

Test Plan

  • Verify that the correct libc variant is selected on an ARM system with and without VFP support.

Cargo.lock Outdated Show resolved Hide resolved
Signed-off-by: Kemal Akkoyun <[email protected]>
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

crates/uv-python/src/cpuinfo.rs Show resolved Hide resolved
crates/uv-python/src/cpuinfo.rs Show resolved Hide resolved
Signed-off-by: Kemal Akkoyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv python install 3.12 is not working on armv7 libc is identify as gnu instead of gnueabihf
3 participants