Add uv build --all option
#7724
Conversation
|
Wondering if we should call this |
|
|
crates/uv/src/commands/build.rs
Outdated
| ) | ||
| }); | ||
|
|
||
| let results = futures::future::join_all(build_futures).await; |
There was a problem hiding this comment.
You could also sort the results for determinism here right? Generally I'm pretty into having deterministic output if it's not high-cost.
There was a problem hiding this comment.
I think the build output itself would be interleaved even if sorted. We'd need --no-build-output from your prior PR... then we could make the asset names deterministic, I think.
There was a problem hiding this comment.
We would need that.. wouldn't we :p I feel like in this case it'd probably make sense to do something else with the build output by default instead of interleaving it... like show progress bars for each build and write the output to a file per project or something. Anyway, that doesn't need to be in scope here.
Cross-linking for reference #7675
|
I guess |
|
I'd be down to restore #7675 as a hidden option so we can use it here and consider if we want it in the long run? |
|
Sounds good. I re-opened and approved. |
| Building source distribution... | ||
| Building wheel from source distribution... | ||
| Building wheel from source distribution... | ||
| Successfully built packages/member_a/dist/member_a-0.1.0.tar.gz and packages/member_a/dist/member_a-0.1.0-py3-none-any.whl |
There was a problem hiding this comment.
Should every member write to a single top-level ./dist? I'm actually not sure. What does Rye do? In this PR, you're writing to ./dist relative to each member.
There was a problem hiding this comment.
I guess this is fine. I'm not sure what's best. Rye writes to a single ./dist.
charliermarsh
force-pushed
the
build-all
branch
from
a41586c
to
2262983
Compare
charliermarsh
force-pushed
the
build-all
branch
from
2262983
to
98b6c78
Compare
|
Thanks! |
…l` (#7736) ## Summary Small follow up to #7724 ## Test Plan `cargo test` --------- Co-authored-by: Charlie Marsh <[email protected]>
Summary
Resolves #7705
Test Plan
cargo testand tested locally.The snapshots were unstable due to the packages being built in a non-deterministic order, so I used the quiet flag to suppress the output.
Another question is whether we should label the build output to indicate which package it belongs to?