-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock and resolve with project name where available #7488
Conversation
This populates the project package name (if available) for lock-and-resolve operations.
.pyproject_toml() | ||
.project | ||
.as_ref() | ||
.map(|proj| proj.name.clone()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: drive-by fix, I noticed this detail was missing when looking into a derivation tree result from PubGrub. I think in practice this should be a no-op change for any observable behavior, but I'll let CI check that.
I believe the PubGrub "root" package is intentionally uv/crates/uv-resolver/src/pubgrub/report.rs Lines 361 to 368 in 5e1b9b1
uv/crates/uv-resolver/src/error.rs Lines 619 to 626 in 4ff057e
I think adding the name here would be confusing, since we'd have |
What you say makes plenty of sense in the context of workspaces with packages, and I'm inclined to drop this PR as it may have some side-effect implications that I currently can't fully evaluate. At the same time, it is notable that this is the only invocation of uv/crates/uv-requirements/src/specification.rs Lines 229 to 232 in df90cc6
|
This populates the project package name (if available) for lock-and-resolve operations.