Move formatting of explanations into the report formatter #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/add-report-explain
branch
from
0e02ea9
to
3e52302
Compare
zanieb
force-pushed
the
zb/add-report-explain
branch
from
3e52302
to
b9d69be
Compare
zanieb
added a commit
to astral-sh/uv
that referenced
this pull request
Jan 10, 2024
Closes #810 Closes #812 Requires astral-sh/pubgrub#19 and astral-sh/pubgrub#18 - Always pair package ranges with names e.g. `... of a matching a<1.0` instead of `... of a matching <1.0` - Split range segments onto multiple lines when not a singleton as suggested in [#850](#850 (comment)) - Improve formatting when ranges are split across multiple lines e.g. by avoiding extra spaces and improving wording Note review will require expanding the hidden files as there are significant changes to the report formatter and snapshots. Bear with me here as these are definitely not perfect still. The following changes build on top of this independently for further improvements: - #868 - #867 - #866 - #871
|
As I recall, this was one of the things I was working on in my refactor of the formatting trait. Of course, mine was just a spike and completely unmoored from actual users needs. When you figure out what a user will use, I look forward to up screaming this! |
konstin
pushed a commit
that referenced
this pull request
Mar 6, 2024
konstin
pushed a commit
that referenced
this pull request
Mar 12, 2024
konstin
pushed a commit
that referenced
this pull request
Mar 12, 2024
konstin
pushed a commit
that referenced
this pull request
Mar 13, 2024
konstin
pushed a commit
that referenced
this pull request
Mar 22, 2024
konstin
pushed a commit
that referenced
this pull request
May 2, 2024
konstin
pushed a commit
that referenced
this pull request
May 2, 2024
konstin
added a commit
that referenced
this pull request
May 7, 2024
…rub-rs#214) Co-authored-by: Zanie Blue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves formatting of explanations into the report formatter trait allowing customization by users outside of the library.