Fixed invalid rounding in formatDuration

asticode · Mar 20, 2024 · 967700d · 967700d
1 parent 6c644f7
commit 967700d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/subtitles.go b/subtitles.go
@@ -822,8 +822,8 @@ func formatDuration(i time.Duration, millisecondSep string, numberOfMillisecondD
 	s += strconv.Itoa(seconds) + millisecondSep
 
 	// Parse milliseconds
-	var milliseconds = float64(n/time.Millisecond) / float64(1000)
-	s += fmt.Sprintf("%."+strconv.Itoa(numberOfMillisecondDigits)+"f", milliseconds)[2:]
+	var milliseconds = math.Floor(float64(n) / float64(time.Millisecond) / float64(math.Pow(10, 3-float64(numberOfMillisecondDigits))))
+	s += astikit.StrPad(strconv.FormatFloat(milliseconds, 'f', 0, 64), '0', numberOfMillisecondDigits, astikit.PadLeft)
 	return
 }
 

diff --git a/subtitles_internal_test.go b/subtitles_internal_test.go
@@ -63,4 +63,6 @@ func TestFormatDuration(t *testing.T) {
 	assert.Equal(t, "03:25:45,678", s)
 	s = formatDuration(34*time.Hour+17*time.Minute+36*time.Second+789*time.Millisecond, ",", 3)
 	assert.Equal(t, "34:17:36,789", s)
+	s = formatDuration(12*time.Hour+34*time.Minute+56*time.Second+999*time.Millisecond, ",", 2)
+	assert.Equal(t, "12:34:56,99", s)
 }