Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export ESM modules with rollup #222

Merged
merged 4 commits into from
Apr 5, 2024
Merged

export ESM modules with rollup #222

merged 4 commits into from
Apr 5, 2024

Conversation

AGalabov
Copy link
Collaborator

@AGalabov AGalabov commented Apr 2, 2024

Alternative approach to ESM modules using Rollup as dev dependency

@@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
node-version: [14.x, 16.x, 18.x]
Copy link
Collaborator Author

@AGalabov AGalabov Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollup uses ??= internally which is not valid in node 14. I don't like the fact that we had to do this change but at the same time I do not think that it is too much of a problem since it is not even activelty supported anymore 🤔 . We might be better off adding 20.x instead imho

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird, are you sure it's not configurable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's rollup's source code 🤔 I don't think we can configure that (at least I did not find any options and don't think there are). If we wanted to we probably can introduce Babel and try and convert it to old syntax ... not sure if there's any point.

@danielkarso-pon
Copy link

This PR looks good. I would prefer this over my PR!

@AGalabov AGalabov merged commit 8773c3e into master Apr 5, 2024
3 checks passed
@AGalabov AGalabov deleted the rollup branch April 5, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants