Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major rework - don't merge yet! #43

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

jonschlinkert
Copy link
Member

I just wanted to get this pushed up. we can leave the pr open until everyone things it's good to merge.

There is a lot here, but the main thing I focused on was subgenerators. I started documentation for them, but not all of them have been created. Since @doowb already put the helper/plugin generators together, it might be good to use those somehow when a user runs yo assemble:helper etc. But I'm not sure how that works yet.

Also, I probably broke the gruntfile! sorry @hariadi, I haven't had a chance to test or fix issues - I'm still working on this.

If anyone else wants to add to this pr, with templates, tests, fixes, whatever, please do!!! Let's make this a first class generator! (I might even add themes!)

@jonschlinkert jonschlinkert changed the title don't merge yet major rework - don't merge yet! Mar 24, 2014
@hariadi
Copy link
Member

hariadi commented Mar 24, 2014

💯

themes? 1000X 👍

@jonschlinkert
Copy link
Member Author

what do you think so far @hariadi? I think the structure and flow is feeling pretty good, so I can start working on actual templates/content next.

@hariadi
Copy link
Member

hariadi commented Mar 30, 2014

👍

I'm working on configstore in my local. It's ok with current structure?

@hariadi
Copy link
Member

hariadi commented Mar 31, 2014

Ahhh.. I see you already use configstore. 👍

@jonschlinkert
Copy link
Member Author

yeah, it seems to work great. basically it just saves a few values from the previous run. any time you change one of those values, you will be presented with the new value(s) on the next run.

* adds basic theme and site scaffold
* adds blog theme for blog page
* adds several UI components
* adds disqus include and placeholder config
* uses `git clone` instead of bower to download bootstrap
* adds navigation plugin and resolve helper
*
* externalizes `setup` grunt task, and have it self-delete after first run
* adds two starter themes
* additional less components
* helpers: webfonts, analytics
* plugins: navigation, wordcount
@pburtchaell
Copy link

Hey @jonschlinkert and @hariadi if there is anything I can do to help out here, I would be happy to. I could work on LESS and Sass support as requested in #48 as well as Foundation 5 support as requested in #46.

@jonschlinkert
Copy link
Member Author

@pburtchaell awesome, that would be great! on a related note, might be good to do a skype call or something to update you on what we're planning in general

@pburtchaell
Copy link

Certainly @jonschlinkert. I will be on vacation from tomorrow to August 10 so I'll be fairly free; send me an email at [email protected] or a DM on Twitter and we can plan out a call.

@jonschlinkert
Copy link
Member Author

@pburtchaell sounds like a plan!

@pburtchaell
Copy link

So my thoughts are to split the generator several parts:

  1. Have a main generator for your gruntfile, package.json, and some example markdown, handlebar files, etc —all that you need to generate HTML pages.
  2. Have a sub-generator for CSS (and maybe JS?) —choose from bootstrap, foundation, or no framework (no framework being just a CSS compiler task where you can choose either Sass or LESS).
  3. Have a blog sub-generator.

What do you think everyone?

@jonschlinkert
Copy link
Member Author

Well, we might want to hold off until we release the next version. Actually related to the call I mentioned.

Have you seen the pr?

Sent from my iPhone

On Jul 23, 2014, at 10:26 PM, Patrick Burtchaell [email protected] wrote:

So my thoughts are to split the generator several parts:

Have a main generator for your gruntfile, package.json, and some example markdown, handlebar files, etc —all that you need to generate HTML pages.

Have a sub-generator for CSS (and maybe JS?). Choose from bootstrap, foundation, or no framework (just a CSS compiler task where you can choose either Sass or LESS).

Have a blog sub-generator.

What do you think everyone?


Reply to this email directly or view it on GitHub.

@pburtchaell
Copy link

I did not actually... for some reason I assumed it wasn't a major change because of the small # of commits, but I just checked out the PR. Looks good. And yeah, we can discuss on a call.

@salbaldovinos
Copy link

I'd love to see #46 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants