Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't cancel concurrent main builds #342

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented May 8, 2024

Fixing this in all our rulesets.

This updates the GHA ci.yaml concurrency block to match all of our other rule sets. In particular, the cancel-in-progress is updated to not cancel in progress main builds ${{ github.ref_name != 'main' }} so that if two commits land on main back-to-back the 2nd one does not cancel the first if it is still running CI.

@gregmagolan
Copy link
Member Author

gregmagolan commented May 8, 2024

Oddly I got the following checksum error on the test-release CI job:

INFO: Repository aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64 instantiated at:
  <builtin>: in <toplevel>
Repository rule prebuilt_tool_repo defined at:
  /tmp/tmp.Bya2tw5Cxt/external/aspect_rules_py~override/py/private/toolchain/tools.bzl:147:37: in <toplevel>
ERROR: An error occurred during the fetch of repository 'aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64':
   Traceback (most recent call last):
	File "/tmp/tmp.Bya2tw5Cxt/external/aspect_rules_py~override/py/private/toolchain/tools.bzl", line 134, column [22](https://github.com/aspect-build/rules_py/actions/runs/9009670158/job/24754572411?pr=342#step:3:23), in _prebuilt_tool_repo_impl
		rctx.download(
Error in download: java.io.IOException: Error downloading [https://github.com/aspect-build/rules_py/releases/download/v0.7.3/unpack-x86_64-unknown-linux-gnu] to /tmp/tmp.Bya2tw5Cxt/external/aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64/unpack: Checksum was 35fc4335877a852a6fa1bd3ac2f99d756376ef8540d1bfa36ac7abf9c4fcc8f8 but wanted fd265552bfd[23](https://github.com/aspect-build/rules_py/actions/runs/9009670158/job/24754572411?pr=342#step:3:24)6efef519f81ce783322a50d8d7ab5af5d08a713e519cedff87f
ERROR: <builtin>: fetching prebuilt_tool_repo rule //:aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64: Traceback (most recent call last):
	File "/tmp/tmp.Bya2tw5Cxt/external/aspect_rules_py~override/py/private/toolchain/tools.bzl", line 134, column 22, in _prebuilt_tool_repo_impl
		rctx.download(
Error in download: java.io.IOException: Error downloading [https://github.com/aspect-build/rules_py/releases/download/v0.7.3/unpack-x86_64-unknown-linux-gnu] to /tmp/tmp.Bya2tw5Cxt/external/aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64/unpack: Checksum was 35fc4335877a852a6fa1bd3ac2f99d756376ef8540d1bfa36ac7abf9c4fcc8f8 but wanted fd[26](https://github.com/aspect-build/rules_py/actions/runs/9009670158/job/24754572411?pr=342#step:3:27)5552bfd236efef519f81ce783322a50d8d7ab5af5d08a713e519cedff87f
INFO: Repository rules_python~0.29.0~python~python_3_11_x86_64-unknown-linux-gnu instantiated at:
  <builtin>: in <toplevel>
Repository rule python_repository defined at:
  /tmp/tmp.Bya2tw5Cxt/external/rules_python~0.29.0/python/repositories.bzl:397:36: in <toplevel>
ERROR: no such package '@@aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64//': java.io.IOException: Error downloading [https://github.com/aspect-build/rules_py/releases/download/v0.7.3/unpack-x86_64-unknown-linux-gnu] to /tmp/tmp.Bya2tw5Cxt/external/aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64/unpack: Checksum was 35fc4335877a852a6fa1bd3ac2f99d756376ef8540d1bfa36ac7abf9c4fcc8f8 but wanted fd265552bfd236efef519f81ce783322a50d8d7ab5af5d08a713e519cedff87f
ERROR: /home/runner/work/rules_py/rules_py/e2e/use_release/BUILD.bazel:3:10: //:main depends on @@aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64//:venv_toolchain in repository @@aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64 which failed to fetch. no such package '@@aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64//': java.io.IOException: Error downloading [https://github.com/aspect-build/rules_py/releases/download/v0.7.3/unpack-x86_64-unknown-linux-gnu] to /tmp/tmp.Bya2tw5Cxt/external/aspect_rules_py~override~py_tools~rules_py_tools.linux_amd64/unpack: Checksum was 35fc4335877a852a6fa1bd3ac2f99d756376ef8540d1bfa36ac7abf9c4fcc8f8 but wanted fd265552bfd236efef519f81ce783322a50d8d7ab5af5d08a713e519cedff87f

Fixed in 2nd commit

Copy link
Member

@mattem mattem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit body with the motivation and reasons behind this change and split into two PRs for landing.

@gregmagolan
Copy link
Member Author

Please update the commit body with the motivation and reasons behind this change and split into two PRs for landing.

Looks like main was broken on the last landed commit by this PR #333. I'll pre-factor the fix into a separate PR.

@gregmagolan gregmagolan merged commit e1437d4 into main May 9, 2024
14 checks passed
@gregmagolan gregmagolan deleted the concurrency_fix branch May 9, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants