chore: improve error message for py_runtime missing version info #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a python toolchain is added directly using
py_runtime
, etc, the interpreter_version_info attribute (a dict) is required.Prior to this change, it would fail in e.g. _py_binary_rule_impl with an error:
Check this in earlier in _resolve_toolchain where we find the "interpreter_version_info" attribute, ensuring that it has all of the required dict keys.
Test plan
Manual testing.
From this toolchain definition: