Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
thesayyn committed Sep 4, 2024
1 parent 9a06cd8 commit 8c38868
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions py/private/py_pex_binary.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def _py_python_pex_impl(ctx):
args.add_all(
ctx.attr.inject_env.items(),
map_each = lambda e: "--inject-env={}={}".format(e[0], e[1]),
# this is needed to allow passing a lambda (with workspace_name) to map_each
# this is needed to allow passing a lambda to map_each
allow_closure = True,
)

Expand Down Expand Up @@ -116,11 +116,7 @@ def _py_python_pex_impl(ctx):
)

return [
DefaultInfo(files = depset([output]), executable = output),
# See: https://github.com/bazelbuild/bazel/blob/b4ab259fe1cba8a108f1dd30067ee357c7198509/src/main/starlark/builtins_bzl/common/python/py_executable_bazel.bzl#L265
OutputGroupInfo(
python_zip_file = depset([output])
)
DefaultInfo(files = depset([output]), executable = output)
]


Expand Down

0 comments on commit 8c38868

Please sign in to comment.